3748 - Keyboard accelerators, shortcuts not displayed in menus

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[cpratt]

In apprunner, neither keyboard accelerators nor shortcuts are displayed in
menus.

Comment 1

[shuang (gone)]

These will be added later. Re-assign it to German who is responsible for the UI
design.
--Shuang

Comment 2

[german]

Agreed - but this not implemented yet as far as I know. Actually I will hand
this over to chris who I believe is implementing some of the menu stuff.

Comment 3

[Peter Trudelle]

targeting m4, p3

Comment 4

[saari (gone)]

Changing to M5... no keyboard accelerators to show

Comment 5

[saari (gone)]

Keyboad binding isn't going to be in until M6, moving to M7

Comment 6

[Claudius Gayle]

QA assigning several orphaned UI/UE bugs. cpratt, I'm giving you the ones you wrote :-), and I'll take the rest.

Comment 7

[saari (gone)]

This is a duplicate of a billion other bugs I have

Comment 8

[saari (gone)]

Keyboard shortcuts are coming in M8. You might yet see shortcuts in menus if the
tree ever opens and stays green.

Comment 9

[saari (gone)]

This is in for M8, so I'm going to mark as fixed. (linux still needs attention,

but I expect that to make it in before tonight's M8 deadline)

Comment 10

[cpratt]

Don't see it in the 1999070608 builds. Which build should this be in - the 7
July builds?

Comment 11

[cpratt]

I don't see anything in the 1999070708 M8 build either. Reopening and clearing
resolution.

Comment 12

[saari (gone)]

No... I didn't add any of the accelerators or access keys to any of the XUL
files, so unless you did, you won't see them, but they do work.

<menu accesskey="x" key="key tag id"> is the syntax. You of course need a keyset
and key tags within it to reference, and the accesskey must be in the menu name.

Comment 13

[saari (gone)]

apparently these are not in on GTK yet

Comment 14

[saari (gone)]

Pushing to M9 as this isn't critical (and mostly fixed anyway)

Comment 15

[saari (gone)]

This should be fixed by XPMenus. Pav said that Hyatt said it works...

Marking fixed

Comment 16

[cpratt]

I don't see them in the Editor component - should I mark this verified and open
a new bug, or just reopen this bug?

Comment 17

[cpratt]

They aren't in the menus proper either - although the F in File is underlined,
for example, neither accelerators nor shortcuts exist in the menus themselves
(in the 1999080508 build). Was this to be fixed in a later build or shall I
reopen this bug?

Comment 18

[saari (gone)]

The functionality is there, I'm not sure if any of the XUL files use it yet.

Comment 19

[semperubisububi]

In (1999080908) there are no shortcuts inside the menus.  For instance no cut
and paste, no find in page.  (in netscape this is ctrl-f or alt-f depending on
your os).  I haven't checked this on linux but it appears to be so on win98

Comment 20

[leger]

Clearing resolution due to reopen of bug.

Comment 21

[chris hofmann]

chris,  should this bug now go to someone else to get xul hooked up?
-> m10

Comment 22

[saari (gone)]

Yes, this bug should go to someone else to hook up. Look at editor, they are
using these things.

Comment 23

[saari (gone)]

The functionality is there. Editor uses it.

Peter, can you kill this bug or toss it to someone more appropriate? Thanks.

Comment 24

[Peter Trudelle]

I think this bug is ready to go back to german.  Support is in, but I don't know
of any spec for what should appear in the menus. Once there is a spec, we can
report any discrepancies against the individual components.

Comment 25

[shuang (gone)]

Spec is updated for this.
cpratt, can you see whether you can split this bug based on spec( check it out
on gooey), or let me know
if you think I should do this (I am at this moment is German....;-)

Comment 26

[chris hofmann]

m11.  let me know if we can get this going in the next couple of days.

Comment 27

[cpratt]

shaung, I'm not sure I completely understand your comments, but I think we can
close this one out for now. It's obviously possible to add accelerators and
shortcuts to menus; from here on out, I suspect we'll be filing bugs on a case
by case basis (for each broken/missing shortcut/accelerator). OK?

Comment 28

[german]

Yes, sounds good. The spec is now available with accelerators and menmonics,
feel free to file bugs for each menu separately if we see probs.

Comment 29

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.