Closed
Bug 374820
Opened 17 years ago
Closed 15 years ago
vertical scrollbars showing in the major update / EULA part of the software update UI
Categories
(Toolkit :: Application Update, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: moco, Assigned: robert.strong.bugs)
References
(Depends on 1 open bug)
Details
(4 keywords)
Attachments
(4 files)
160.25 KB,
image/jpeg
|
Details | |
140.25 KB,
image/jpeg
|
Details | |
546 bytes,
patch
|
mossop
:
review+
beltzner
:
approval1.9.1+
dveditz
:
approval1.9.0.9+
|
Details | Diff | Splinter Review |
10.11 KB,
image/jpeg
|
Details |
vertical scrollbars showing in the major update / EULA part of the software update UI screen shots coming. to reproduce, set your app.update.url.override pref to http://www.sspitzer.org/empty.xml I'm on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a3pre) Gecko/20070208 Minefield/3.0a3pre This is a regression, but I don't think the software update xul / css has changed at all recently.
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Comment 2•17 years ago
|
||
Reporter | ||
Comment 3•17 years ago
|
||
note, it is the outer most (right) scroll bar that is new, and was not there before. the inner most scroll bar is supposed to be there because the content is too tall for the xulbrowser.
Updated•16 years ago
|
Product: Firefox → Toolkit
Assignee | ||
Comment 4•16 years ago
|
||
Appears to also affect weave. Bug 442868
Assignee | ||
Comment 5•15 years ago
|
||
This appears to fix it on a QA system for me. I believe the buttons along the bottom are the culprit.
Assignee: nobody → robert.bugzilla
Attachment #359633 -
Flags: review?(dtownsend)
Assignee | ||
Comment 6•15 years ago
|
||
filed bug 476048 for the underlying issue with Wizards on Mac OS X.
Assignee | ||
Comment 7•15 years ago
|
||
Dave, could you also verify this fixes this since I don't have a Mac? I did my testing on one of the QA machines and believe this is a decent workaround for this issue. Thanks
Updated•15 years ago
|
Attachment #359633 -
Flags: review?(dtownsend) → review+
Comment 8•15 years ago
|
||
Comment on attachment 359633 [details] [diff] [review] patch rev1 Yes this fixes the issue
Assignee | ||
Comment 9•15 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/759e7042e2d1
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Attachment #359633 -
Flags: approval1.9.1?
Assignee | ||
Comment 10•15 years ago
|
||
Comment on attachment 359633 [details] [diff] [review] patch rev1 Drivers, this is an extremely simple polish fix for the vertical scrollbar appearing in the update ui on Mac OS X.
Assignee | ||
Updated•15 years ago
|
Priority: -- → P3
Assignee | ||
Comment 11•15 years ago
|
||
Requesting wanted1.9.0.x since this is an extremely safe fix and it would be nice if Mac users didn't have to see that unnecessary scrollbar when we release 3.1
Flags: wanted1.9.0.x?
Updated•15 years ago
|
Flags: blocking1.9.1+
Priority: P3 → P2
Comment 12•15 years ago
|
||
Comment on attachment 359633 [details] [diff] [review] patch rev1 a191=beltzner
Attachment #359633 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 13•15 years ago
|
||
Pushed to mozilla-1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4e235c238483
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
Assignee | ||
Updated•15 years ago
|
Attachment #359633 -
Flags: approval1.9.0.8?
Attachment #359633 -
Flags: approval1.9.0.7?
Assignee | ||
Comment 14•15 years ago
|
||
Comment on attachment 359633 [details] [diff] [review] patch rev1 1.9.0.x drivers, this is a simple / safe fix that would be to get in for 1.9.0.x so Mac users won't have to see the unnecessary scrollbar when we release 3.1.
Comment 15•15 years ago
|
||
Rob, the box looks still a bit displaced. See the attachment. Shall I file a new bug on that?
Updated•15 years ago
|
Attachment #359633 -
Flags: approval1.9.0.7?
Assignee | ||
Comment 16•15 years ago
|
||
(In reply to comment #15) > Created an attachment (id=361829) [details] > displaced background of update box > > Rob, the box looks still a bit displaced. See the attachment. Shall I file a > new bug on that? That is controlled by the remote html / css and hence is not an app update bug... you should file a websites -> www.mozilla.com bug to have that fixed
Comment 17•15 years ago
|
||
(In reply to comment #16) > That is controlled by the remote html / css and hence is not an app update > bug... you should file a websites -> www.mozilla.com bug to have that fixed Unless its a test I think I'll wait with filing a new bug on that. I'll do it when we will have a real billboard available. Meanwhile I can verify the fix with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090211 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090211020510 Rob, I don't think that there is a way to verify it on trunk right now?
Keywords: fixed1.9.1 → verified1.9.1
Comment 18•15 years ago
|
||
Comment on attachment 359633 [details] [diff] [review] patch rev1 Approved for 1.9.0.8, a=dveditz for release-drivers
Attachment #359633 -
Flags: approval1.9.0.8? → approval1.9.0.8+
Assignee | ||
Comment 19•15 years ago
|
||
Bah... I landed it but the tree still states requirement for approval1.9.0.7 on patches so I backed it out until it is open for 1.9.0.8.
Comment 20•15 years ago
|
||
The tree rules were a lie! Please re-land and sorry about that.
Assignee | ||
Comment 21•15 years ago
|
||
Landed for 1.9.0.8 / Firefox 3.0.8 Checking in mozilla/toolkit/themes/pinstripe/mozapps/update/updates.css; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/update/updates.css,v <-- upd ates.css new revision: 1.10; previous revision: 1.9 done
Keywords: fixed1.9.0.8
Assignee | ||
Updated•15 years ago
|
Flags: wanted1.9.0.x?
Comment 22•15 years ago
|
||
Verified for 1.9.0.8 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.8pre) Gecko/2009031904 GranParadiso/3.0.8pre.
Keywords: fixed1.9.0.8 → verified1.9.0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•