Closed Bug 374937 Opened 17 years ago Closed 17 years ago

Crashes [@ nsTypedSelection::GetFrameSelection]

Categories

(Core :: DOM: Selection, defect)

Product:
Core
Component:
DOM: Selection
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

proposed patch
1004 bytes, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
Attached patch proposed patch — — Splinter Review 
According to TB, there are some crashes at nsTypedSelection::GetFrameSelection.
The problem seems to be that mFrameSelection can be nsnull, 
so NS_IF_ADDREF should be used.
if(!mFrameSelection) is checked elsewhere in nsTypedSelection.
Attachment #259332 - Flags: superreview?(roc)
Attachment #259332 - Flags: review?(roc)
Attachment #259332 - Flags: superreview?(roc)
Attachment #259332 - Flags: superreview+
Attachment #259332 - Flags: review?(roc)
Attachment #259332 - Flags: review+
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: