Closed Bug 374944 Opened 15 years ago Closed 15 years ago

Places toolkit tests should move into /toolkit

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dietrich, Assigned: dietrich)

Details

Attachments

(1 file, 1 obsolete file)

All the Places tests are currently in browser. The tests that are specific to the Places toolkit APIs need to be moved into toolkit.
Assignee: nobody → dietrich
Attached patch fix v1 (obsolete) — Splinter Review
all the tests are api-focused right now, not /browser specific, so this just does a wholesale move of the tests to toolkit. ran them in the new location, and they pass.
Attachment #259345 - Flags: review?(sayrer)
Comment on attachment 259345 [details] [diff] [review]
fix v1

rs=sayrer
Attachment #259345 - Flags: review?(sayrer) → review+
Attached patch fix v2Splinter Review
accidentally left an unrelated patch mixed in there
Attachment #259345 - Attachment is obsolete: true
dietrich, if you land before me (see bug #369887), I'll move my patch to /toolkit

thanks for moving the tests.
Checking in browser/components/places/Makefile.in;
/cvsroot/mozilla/browser/components/places/Makefile.in,v  <--  Makefile.in
new revision: 1.5; previous revision: 1.4
done
Removing browser/components/places/tests/Makefile.in;
/cvsroot/mozilla/browser/components/places/tests/Makefile.in,v  <--  Makefile.in
new revision: delete; previous revision: 1.5
done
Removing browser/components/places/tests/testbookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/testbookmarks.js,v  <--  testbookmarks.js
new revision: delete; previous revision: 1.14
done
Removing browser/components/places/tests/bookmarks/head_bookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/bookmarks/head_bookmarks.js,v  <--  head_bookmarks.js
new revision: delete; previous revision: 1.2
done
Removing browser/components/places/tests/bookmarks/tail_bookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/bookmarks/tail_bookmarks.js,v  <--  tail_bookmarks.js
new revision: delete; previous revision: 1.1
done
Removing browser/components/places/tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: delete; previous revision: 1.6
done
Removing browser/components/places/tests/bookmarks/test_livemarks.js;
/cvsroot/mozilla/browser/components/places/tests/bookmarks/test_livemarks.js,v  <--  test_livemarks.js
new revision: delete; previous revision: 1.1
done
Removing browser/components/places/tests/chrome/Makefile.in;
/cvsroot/mozilla/browser/components/places/tests/chrome/Makefile.in,v  <--  Makefile.in
new revision: delete; previous revision: 1.1
done
Removing browser/components/places/tests/chrome/sample_feed.atom;
/cvsroot/mozilla/browser/components/places/tests/chrome/sample_feed.atom,v  <--  sample_feed.atom
new revision: delete; previous revision: 1.1
done
Removing browser/components/places/tests/chrome/test_add_livemark.xul;
/cvsroot/mozilla/browser/components/places/tests/chrome/test_add_livemark.xul,v  <--  test_add_livemark.xul
new revision: delete; previous revision: 1.2
done
Removing browser/components/places/tests/unit/head_bookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/unit/head_bookmarks.js,v  <--  head_bookmarks.js
new revision: delete; previous revision: 1.5
done
Removing browser/components/places/tests/unit/tail_bookmarks.js;
/cvsroot/mozilla/browser/components/places/tests/unit/tail_bookmarks.js,v  <--  tail_bookmarks.js
new revision: delete; previous revision: 1.3
done
Removing browser/components/places/tests/unit/test_annotations.js;
/cvsroot/mozilla/browser/components/places/tests/unit/test_annotations.js,v  <--  test_annotations.js
new revision: delete; previous revision: 1.2
done
Removing browser/components/places/tests/unit/test_history.js;
/cvsroot/mozilla/browser/components/places/tests/unit/test_history.js,v  <--  test_history.js
new revision: delete; previous revision: 1.4
done
Checking in toolkit/components/places/Makefile.in;
/cvsroot/mozilla/toolkit/components/places/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/Makefile.in,v
done
Checking in toolkit/components/places/tests/Makefile.in;
/cvsroot/mozilla/toolkit/components/places/tests/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/bookmarks/head_bookmarks.js,v
done
Checking in toolkit/components/places/tests/bookmarks/head_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/head_bookmarks.js,v  <--  head_bookmarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/bookmarks/tail_bookmarks.js,v
done
Checking in toolkit/components/places/tests/bookmarks/tail_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/tail_bookmarks.js,v  <--  tail_bookmarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v
done
Checking in toolkit/components/places/tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_livemarks.js,v
done
Checking in toolkit/components/places/tests/bookmarks/test_livemarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_livemarks.js,v  <--  test_livemarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/chrome/Makefile.in,v
done
Checking in toolkit/components/places/tests/chrome/Makefile.in;
/cvsroot/mozilla/toolkit/components/places/tests/chrome/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/chrome/sample_feed.atom,v
done
Checking in toolkit/components/places/tests/chrome/sample_feed.atom;
/cvsroot/mozilla/toolkit/components/places/tests/chrome/sample_feed.atom,v  <--  sample_feed.atom
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/chrome/test_add_livemark.xul,v
done
Checking in toolkit/components/places/tests/chrome/test_add_livemark.xul;
/cvsroot/mozilla/toolkit/components/places/tests/chrome/test_add_livemark.xul,v  <--  test_add_livemark.xul
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/head_bookmarks.js,v
done
Checking in toolkit/components/places/tests/unit/head_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/head_bookmarks.js,v  <--  head_bookmarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/tail_bookmarks.js,v
done
Checking in toolkit/components/places/tests/unit/tail_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/tail_bookmarks.js,v  <--  tail_bookmarks.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/test_annotations.js,v
done
Checking in toolkit/components/places/tests/unit/test_annotations.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_annotations.js,v  <--  test_annotations.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/test_history.js,v
done
Checking in toolkit/components/places/tests/unit/test_history.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_history.js,v  <--  test_history.js
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I checked in a little fix to the makefile in toolkit/components/places/tests/chrome
saw that, thanks rob!
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.