374973 - multiweek/month view jumps to another week when (de)selecting 'tasks in view' from context menu

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Dennis]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.10) Gecko/20070313 Fedora/1.5.0.10-5.fc6 Firefox/1.5.0.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20070213 Sunbird/0.3.1

This behaviour happens when the calendar is displayed in multiweek view and when (de)selecting 'Tasks in View' from the context menu. When you stand with the mouse pointer on any week after the first week in the view, the view is changed to a view with the first week the week you clicked on.
Same holds for month view, when clicked on a day outside the month.

Reproducible: Always

Steps to Reproduce:
1. select multiweek view
2. right click on a week after the first week in your view (eg. when week 26 - 31 is view, rightclick on a day in week 29)
3. (de)select 'Tasks in View'
Actual Results:  
The view is changed to a multiweek view with the first week being the week you clicked on (in the example: week 29).

Expected Results:  
The multiweek view shouldn't change. I asked only for showing tasks in view, not showing other weeks in addition.

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070322 Calendar/0.6a1.

Comment 3

[Decathlon]

Attachment: Patch - v1

There are other actions that cause the same issue, at least the following:
- toggle workdays only;
- toggle tasks in view;
- toggle show completed task in view;
- update offline UI;

in all these cases the refresh of the view is achieved by using the function goToDay() with the selected day as argument.

This patch changes the goToDay() function in order to refresh the view, without changing it, for all the calls with a date equal to the selected day.

Comment 4

[Decathlon]

Comment on attachment 728662 [details] [diff] [review]
Patch - v1

The patch doesn't consider all. A new patch is coming.

Comment 5

[Decathlon]

Attachment: patch - v2

The previous patch treated all the goToDay() requests with the selectedDay as argument in the same way (doing only a refresh of the view), but actually there are requests, like those one for zooming the multiweek view, that need to change the start and end of the view (and hence not only a refresh) even if the passed date is the selected day.

This patch does only a view refresh when a null date is being passed to goToDay() function.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 728992 [details] [diff] [review]
patch - v2

Review of attachment 728992 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp

Comment 7

[Decathlon]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/660427430cdd

Fixed.