375042 - _cairo_image_surface_nil_invalid_format exported, potentially conflicting with system cairo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The symbol _cairo_image_surface_nil_invalid_format is exported from Mozilla's in-tree cairo.  This potentially conflicts with a system cairo (on GTK2, particularly).

I see two possible fixes:
 (1) add it to cairo-rename.h
 (2) mark it as |static| (and push the patch upstream, too)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note:  my source was:

objdump -T libthebes.so | grep "cairo_" | grep -v "_moz_"

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: add to cairo-rename.h

Let's add this to cairo-rename.h for now, and I'll get a static into cairo itself.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed; patch checked in to upstream cairo as well.