Use of uninitialized variable as function return value in nsXULTemplateQueryProcessorRDF.cpp

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: msg, Assigned: enndeakin)

Tracking

unspecified
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.0.04506; .NET CLR 1.1.4322; InfoPath.2)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a3pre) Gecko/20070322 Minefield/3.0a3pre

Durring fuzzing with compile flags to identify use of uninitialized variables it was found that the "rv" variable which is not initialized to any default value in the nsXULTemplateQueryProcessorRDF::Propagate(...) fuction can be returned w/o any value being set in some code paths.  See included URL for bonsai link with source lines highlighted.

A quick at some of the callers of this method show they are not using the return value, so could be a low priority cleanup item.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Assignee: general → nobody
Component: DOM: Core → XP Toolkit/Widgets: XUL
QA Contact: ian → xptoolkit.xul
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

12 years ago
neil, any ideas on this one?
Assignee: nobody → enndeakin
(Assignee)

Comment 2

12 years ago
It could be changed to just return NS_OK. Not a big issue though as no caller actually checks the return value.
(Assignee)

Comment 3

12 years ago
This was fixed with bug 368721
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
(Assignee)

Updated

10 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.