375126 - Characters wrong encoded (shown as code) in mail and add-on details

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It seems as there exist several encoding problems with special characters in remora.

- Line breaks in the reviewer comments are "\r\n" in the mail to the developer.
- Some add-ons have the special characters in the layout like they should look in the source (check out some descriptions, summaries, developer notes). Examples: \r\n " · etc.

They should work properly.

Comment 1

[Fred Wenzel [:wenzel]]

I will fix this during the course of bug 378395, because we'll need to send out a confirmation email that should be encoded correctly.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Line-break confirmation emails correctly

Gettext apparently returns the "\n"s in plain text instead of making them line breaks. So I wrote a helper function to do that where desired.

Comment 3

[Fred Wenzel [:wenzel]]

Thanks for the review, r12867.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

archaeopteryx: any chance you could verify this using https://preview.addons.mozilla.org/en-US/firefox/?  I'm not an add-on developer, so I don't think I have access to that type of email.  Thanks either way!