375143 - footer should have clear:both in css

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Bill Barry]

Attachment: adds clear:both

Being that the image is float:right, the footer and image very quickly collide the moment anyone modifies index.html.tmpl

It would be a good thing to set clear:both on the #footer statement in global.css.

Comment 1

[Bill Barry]

Attachment: with space after colon

fixed comment from LpSolit on irc

Comment 2

[Max Kanat-Alexander]

Bill: For CSS and just UI stuff, probably best to ask myk for review, I think.

Comment 3

[Max Kanat-Alexander]

That's not an insult to LpSolit, by the way--I just am not sure if he wants to review a CSS patch (he can speak for himself, though).

Comment 5

[Frédéric Buclin]

(In reply to comment #3)
> That's not an insult to LpSolit

No worry. :) But I admit that this patch is low priority compared to other reviews waiting for me.

Comment 6

[C.J. Adams-Collier]

I've added a patch that fixes this, too.  I also fixed the float:right'd div#page-index .intro which was an example of the reason why there should be a clear:both on the footer.

https://bugzilla.mozilla.org/attachment.cgi?id=259531&action=diff

Comment 7

[C.J. Adams-Collier]

Attachment: patch to fix div#page-index .intro's clear CSS property

I've attached that diff to this bug as well, since the other was closed but had some other code that will help to avoid footer overlap.

Comment 8

[Frédéric Buclin]

Comment on attachment 259693 [details] [diff] [review]
patch to fix div#page-index .intro's clear CSS property

>Index: skins/standard/index.css
>-    div.contribute {

This block no longer exists. You have to update your installation. Also, do not forget to request review (set the flag to "review?") when attaching a patch so that we get it in our radar.

Comment 9

[Frédéric Buclin]

Comment on attachment 259456 [details] [diff] [review]
with space after colon

r=LpSolit

Comment 10

[Frédéric Buclin]

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.33; previous revision: 1.32
done