375154 - crash [@ mozSpellChecker::mozSpellChecker]

Status: VERIFIED DUPLICATE of bug 316543

(Core :: Spelling checker, defect)

Description

[Samuel Sidler (old account; do not CC)]

There's currently a #9 topcrash for Firefox 2.0.0.3. I'm filing it now so it doesn't get lost and so we can track it, even though I have no STR.

It looks like this crash has happened in all versions of 2.0 as well as the RCs before final release. For all intents and purposes, this isn't happening on the trunk (or isn't visible there), but, based on comments, looks like it's happening as part of startup and, many times, after an update. I'm guessing this crash isn't visible on trunk because not many people are using software update. 

This might also involve using a dictionary other than the one that ships with Firefox as many of the comments seem to be from users whose first language is not English.

Since we don't have very much talkback data going back to releases before the RCs, I can't tell when this started. A possible candidate, based the most recent checkin from parts of the stack, is the checkin for bug 339434 / bug 342748, which happened back on July 26, 2006, so CCing relevant people. (Also see bug 316543, which was fixed way before that but crashed in a similar spot.)

This crash will probably get a bit buried in the reports as time goes on since it appears to happen for a lot of people after software update, but that doesn't make it any less of a topcrash.

Comment 1

[Daniel Veditz [:dveditz]]

As much as this would be nice, I don't think it's a blocker without more hope of a fix (too many other, more serious, bugs).

Comment 2

[timeless]

well this crash is just stupid.

Incident ID: 30771386
Stack Signature	mozSpellChecker::mozSpellChecker 80944d96
Product ID	Firefox2
Build ID	2007021917
Trigger Time	2007-03-31 14:21:46.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	spellchk.dll + (000012c5)
URL visited	
User Comments	
Since Last Crash	1 sec
Total Uptime	204906 sec
Trigger Reason	Access violation
Source File, Line No.	c:/builds/tinderbox/Fx-Mozilla1.8-release/WINNT_5.2_Depend/mozilla/extensions/spellcheck/src/mozSpellChecker.cpp, line 60
Stack Trace 	
mozSpellChecker::mozSpellChecker  [mozilla/extensions/spellcheck/src/mozSpellChecker.cpp, line 60]
mozSpellCheckerConstructor  [mozilla/extensions/spellcheck/src/mozSpellCheckerFactory.cpp, line 63]
CallCreateInstance  [mozilla/xpcom/build/nsComponentManagerUtils.cpp, line 171]
nsEditorSpellCheck::CanSpellCheck  [mozilla/editor/composer/src/nsEditorSpellCheck.cpp, line 91]
mozInlineSpellChecker::CanEnableInlineSpellChecking  [mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 652]
mozInlineSpellCheckerConstructor  [mozilla/extensions/spellcheck/src/mozSpellCheckerFactory.cpp, line 77]
CallCreateInstance  [mozilla/xpcom/build/nsComponentManagerUtils.cpp, line 171]
nsEditor::GetInlineSpellCheckerOptionally  [mozilla/editor/libeditor/base/nsEditor.cpp, line 1411]
nsEditor::SyncRealTimeSpell  [mozilla/editor/libeditor/base/nsEditor.cpp, line 1431]
nsEditor::PostCreate  [mozilla/editor/libeditor/base/nsEditor.cpp, line 339]
nsCSSFrameConstructor::ConstructHTMLFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 5692]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7872]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7748]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 12186]
nsCSSFrameConstructor::ConstructXULFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6397]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7878]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7748]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 12186]
nsCSSFrameConstructor::ConstructXULFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6397]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7878]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7813]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7748]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 12186]
nsCSSFrameConstructor::ConstructXULFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6397]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7878]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7748]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 12186]
nsCSSFrameConstructor::ConstructXULFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6397]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7878]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7748]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 12186]
nsCSSFrameConstructor::ConstructDocElementFrame  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 4607]
nsCSSFrameConstructor::ContentInserted  [mozilla/layout/base/nsCSSFrameConstructor.cpp, line 9286]
PresShell::InitialReflow  [mozilla/layout/base/nsPresShell.cpp, line 2870]
nsXULDocument::StartLayout  [mozilla/content/xul/document/src/nsXULDocument.cpp, line 2283]
nsXULDocument::ResumeWalk  [mozilla/content/xul/document/src/nsXULDocument.cpp, line 3363]
nsXULDocument::OnStreamComplete  [mozilla/content/xul/document/src/nsXULDocument.cpp, line 3651]
nsStreamLoader::OnStopRequest  [mozilla/netwerk/base/src/nsStreamLoader.cpp, line 137]
nsJARChannel::OnStopRequest  [mozilla/modules/libjar/nsJARChannel.cpp, line 712]


http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/spellcheck/src/mozSpellChecker.cpp&mark=58-60&rev=MOZILLA_1_8_BRANCH#60

nothing actually handles the error, except crashing.

Comment 3

[Julien Moorrees]

This is a dupe of 376082 and 373658

Comment 4

[François Gagné]

It seems this is still happening in 2.0.0.4, any trunk patch needing to be promoted to branch?

Comment 5

[Samuel Sidler (old account; do not CC)]

Mike, is this something you can look at? (CCing you based on the bonsai link in comment 2.)

Comment 6

[timeless]

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/extensions/spellcheck/src/mozSpellChecker.cpp&mark=1.11

squishing blocking nomination, this bug is already fixed on trunk.

just back port the fix ...