bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove spellcheck extension from libxul library

RESOLVED WONTFIX

Status

()

Core
Spelling checker
RESOLVED WONTFIX
12 years ago
11 years ago

People

(Reporter: romaxa, Assigned: Scott MacGregor)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
In xulrunner configuration spellcheck extension can be builded only inside libxul library.

I think we should make possible to build spellcheck extension outside libxul as .so library...
(Reporter)

Comment 1

12 years ago
Created attachment 259500 [details] [diff] [review]
First revision, (need more proper review and help)

This implementation still required xpcom_core.a
else we have this undefined references:
..........................
mozPersonalDictionary.o: In function `mozPersonalDictionary::GetWordList(nsIStringEnumerator**)':
spellcheck/src/mozPersonalDictionary.cpp:220: undefined reference to `NS_NewAdoptingStringEnumerator(nsIStringEnumerator**, nsStringArray*)'
mozPersonalDictionary.o: In function `mozPersonalDictionary::Load()':
spellcheck/src/mozPersonalDictionary.cpp:130: undefined reference to `nsSimpleUnicharStreamFactory::GetInstance()'
mozPersonalDictionary.o: In function `nsUniCharEntry':
spellcheck/src/mozPersonalDictionary.h:64: undefined reference to `nsCRT::strdup(unsigned short const*)'
mozPersonalDictionary.o: In function `nsUniCharEntry::KeyEquals(unsigned short const*) const':
spellcheck/src/mozPersonalDictionary.h:78: undefined reference to `nsCRT::strcmp(unsigned short const*, unsigned short const*)'
mozPersonalDictionary.o: In function `nsUniCharEntry::HashKey(unsigned short const*)':
spellcheck/src/mozPersonalDictionary.h:81: undefined reference to `nsCRT::HashCode(unsigned short const*, unsigned int*)'
..................................
(Reporter)

Updated

12 years ago
Attachment #259500 - Flags: review?(mscott)
(Reporter)

Updated

12 years ago
Attachment #259500 - Flags: review?(benjamin)

Comment 2

12 years ago
Comment on attachment 259500 [details] [diff] [review]
First revision, (need more proper review and help)

This doesn't make any sense. Either spellcheck is part of libxul or it's not. We have previously made it part of libxul, because we ship it with the toolkit. Are you asking to reconsider that decision?
Attachment #259500 - Flags: review?(mscott)
Attachment #259500 - Flags: review?(benjamin)
Attachment #259500 - Flags: review-
(Reporter)

Comment 3

12 years ago
You mean bug 339106?, but there are no any decisions... only integrate spellcheck "extension" into libxul... (in this case it will be not extension anymore :( )

My (I hope not only my) idea build libxul library once, and if I want to use something else in future just install it as dynamic component/extension, using frozen API.
I don't want to pre-compile whole world into libxul.

If somebody wants to build it as part of libxul, then there are  should be some define like "IS_DYN_COMPONENT=[1|]" ?
(Reporter)

Comment 4

12 years ago
I think it should be possible to build this extension at least in both variants as part of libxul, and as just extension...

Comment 5

12 years ago
(In reply to comment #3)
> My (I hope not only my) idea build libxul library once, and if I want to use
> something else in future just install it as dynamic component/extension, using
> frozen API.

The spellchecker consumes and exposes many unfrozen interfaces.
(Reporter)

Comment 6

12 years ago
See Comment #1, for building I have found problem only with
NS_NewAdoptingStringEnumerator, nsSimpleUnicharStreamFactory

After fixing this we can easy build spellcheck without xpcom_core.a
 by using glue...

I think it is easy to fix.

Comment 7

12 years ago
I'm not saying it isn't easy to fix. I'm saying I don't see why we should fix it. It is either in the toolkit (and therefore libxul), or it's not. In this case, it is, so I don't see any point adding additional complexity.

Updated

11 years ago
Blocks: 401821

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.