375179 - Remove spellcheck extension from libxul library

Status: RESOLVED WONTFIX

(Core :: Spelling checker, defect)

Description

[Oleg Romashin (:romaxa)]

In xulrunner configuration spellcheck extension can be builded only inside libxul library.

I think we should make possible to build spellcheck extension outside libxul as .so library...

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: First revision, (need more proper review and help)

This implementation still required xpcom_core.a
else we have this undefined references:
..........................
mozPersonalDictionary.o: In function `mozPersonalDictionary::GetWordList(nsIStringEnumerator**)':
spellcheck/src/mozPersonalDictionary.cpp:220: undefined reference to `NS_NewAdoptingStringEnumerator(nsIStringEnumerator**, nsStringArray*)'
mozPersonalDictionary.o: In function `mozPersonalDictionary::Load()':
spellcheck/src/mozPersonalDictionary.cpp:130: undefined reference to `nsSimpleUnicharStreamFactory::GetInstance()'
mozPersonalDictionary.o: In function `nsUniCharEntry':
spellcheck/src/mozPersonalDictionary.h:64: undefined reference to `nsCRT::strdup(unsigned short const*)'
mozPersonalDictionary.o: In function `nsUniCharEntry::KeyEquals(unsigned short const*) const':
spellcheck/src/mozPersonalDictionary.h:78: undefined reference to `nsCRT::strcmp(unsigned short const*, unsigned short const*)'
mozPersonalDictionary.o: In function `nsUniCharEntry::HashKey(unsigned short const*)':
spellcheck/src/mozPersonalDictionary.h:81: undefined reference to `nsCRT::HashCode(unsigned short const*, unsigned int*)'
..................................

Comment 2

[Benjamin Smedberg]

Comment on attachment 259500 [details] [diff] [review]
First revision, (need more proper review and help)

This doesn't make any sense. Either spellcheck is part of libxul or it's not. We have previously made it part of libxul, because we ship it with the toolkit. Are you asking to reconsider that decision?

Comment 3

[Oleg Romashin (:romaxa)]

You mean bug 339106?, but there are no any decisions... only integrate spellcheck "extension" into libxul... (in this case it will be not extension anymore :( )

My (I hope not only my) idea build libxul library once, and if I want to use something else in future just install it as dynamic component/extension, using frozen API.
I don't want to pre-compile whole world into libxul.

If somebody wants to build it as part of libxul, then there are  should be some define like "IS_DYN_COMPONENT=[1|]" ?

Comment 4

[Oleg Romashin (:romaxa)]

I think it should be possible to build this extension at least in both variants as part of libxul, and as just extension...

Comment 5

[Brett Wilson]

(In reply to comment #3)
> My (I hope not only my) idea build libxul library once, and if I want to use
> something else in future just install it as dynamic component/extension, using
> frozen API.

The spellchecker consumes and exposes many unfrozen interfaces.

Comment 6

[Oleg Romashin (:romaxa)]

See Comment #1, for building I have found problem only with
NS_NewAdoptingStringEnumerator, nsSimpleUnicharStreamFactory

After fixing this we can easy build spellcheck without xpcom_core.a
 by using glue...

I think it is easy to fix.

Comment 7

[Benjamin Smedberg]

I'm not saying it isn't easy to fix. I'm saying I don't see why we should fix it. It is either in the toolkit (and therefore libxul), or it's not. In this case, it is, so I don't see any point adding additional complexity.