3752 - NS_MOUSE_LEFT_CLICK doesn't work

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

I don't ever get NS_MOUSE_LEFT_CLICK events. I only seem to get
NS_MOUSE_LEFT_BUTTON_UP events instead.

Not sure if this is mac-only, but i suspect not.

Comment 1

[joki (gone)]

NS_MOUSE_LEFT_CLICK events are generated for the content internally, not the
OS.  I need more clarification on where and why you're looking for these to do
anything with this?

Comment 2

[Mike Pinkerton (not reading bugmail)]

I'd rather check for a click than a button up to see if there is a mouse click.
If that's not the way it should be, though, then i'll deal. Just wondering why
there was a high level event if no one was supposed to look for it.

Comment 3

[joki (gone)]

You can just for a click.  I guess my point was that we generate these
internally based on our own restriction.  ie. a mousedown and up on the same
content object is a click.  A mousedown then up elsewhere is not.  So where is
it that you don't get these?  I can't really fix this without more specific
info.

Comment 4

[Mike Pinkerton (not reading bugmail)]

In the toolbox frame event handling code, i don't get "clicks" only downs and ups
(nsToolboxFrame).

Comment 5

[joki (gone)]

Well its pretty much fixed but let me explain the problem.  We dispatch events
based on content, not frames.  So in fact we are dispatching the click, we're
just sending it to the content.  I've added it so that we also dispatch the
event to the frame we got the mouseup over but keep in mind this is less
reliable.  If there are multiple frames associated with a piece of content only
one of them will get the click.  But this should serve your purpose for the
moment anywyay.

Comment 6

[Mike Pinkerton (not reading bugmail)]

joki, please smack me if i'm being lame, but it still doesn't work quite right so
i'm reopening the bug. When I get the NS_MOUSE_LEFT_CLICK event, the mouse
location (aEvent->point) is garbage (at least the y value us) so it's pretty much
useless.

Everything is ok if I continue to use NS_MOUSE_LEFT_BUTTON_UP.

Comment 7

[Mike Pinkerton (not reading bugmail)]

clearing resolution

Comment 8

[joki (gone)]

Hey, I fixed a bug with click event coords the other day that should have fixed
this too.

Comment 9

[Mike Pinkerton (not reading bugmail)]

how about letting me try it before you mark it fixed ;)

Comment 10

[joki (gone)]

Nope.  No chance.  Its fixed.  They're all fixed.  Muhahahahaha

Comment 11

[Jan Carpenter]

pinkerton, to verify or not to verify?  Is it fixed?

Comment 12

[Mike Pinkerton (not reading bugmail)]

marking verified.