Closed
Bug 375243
Opened 18 years ago
Closed 18 years ago
Remove some unused browser strings
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha4
People
(Reporter: philor, Assigned: philor)
Details
Attachments
(1 file)
18.54 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
I bet it adds a lot to the fun of doing a new locale, or QAing an old one, having to guess what strings are unused, or which are duplicates of others elsewhere that are actually used, or in what context an unused string might hypothetically be used in some unimagined future.
I'd like to take some of that fun away.
Attachment #259549 -
Flags: review?(mano)
Comment 1•18 years ago
|
||
Comment on attachment 259549 [details] [diff] [review]
Fix v.1
I didn't check the strings itself, but this is a really good idea, thanks for this. Scary how much you found, too.
One question on the patch, you changed the position of historyShowSidebarCmd.label to be below the
<!-- XXX remove above if places sticks -->
comment, was that intentional?
Assignee | ||
Comment 2•18 years ago
|
||
It was: both places and placeless are using that same entity now, so "if places sticks" resolves down to nothing but a different entity name for the string "Home".
Comment 3•18 years ago
|
||
Comment on attachment 259549 [details] [diff] [review]
Fix v.1
r=mano.
Attachment #259549 -
Flags: review?(mano) → review+
Assignee | ||
Comment 4•18 years ago
|
||
browser/locales/en-US/chrome/browser/aboutDialog.dtd: 1.8
browser/locales/en-US/chrome/browser/browser.dtd: 1.60
browser/locales/en-US/chrome/browser/browser.properties: 1.35
browser/locales/en-US/chrome/browser/openLocation.dtd: 1.3
browser/locales/en-US/chrome/browser/page-drawer.dtd: delete
browser/locales/en-US/chrome/browser/pageInfo.dtd: 1.9
browser/locales/jar.mn: 1.64
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•