375288 - Provide visual feedback while waiting for the installation prompt to show up

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Adam Kowalczyk]

When the install link is clicked an XMLHttpRequest is sent to trigger the installation. Depending on user's connection and network conditions it may take a few seconds for the installation prompt to show up. During that time there's no indication that clicking the link worked. A couple of times I found myself repeatedly clicking it and getting as many installation dialogs.

Displaying some kind of a throbber when the link is clicked would probably help to avoid this issue.

Comment 1

[Wladimir Palant]

There is no XMLHttpRequest and no dependency on the network connection AFAICT. This link simply calls InstallTrigger - does it attempt to connect before showing the dialog?

Comment 2

[Adam Kowalczyk]

(In reply to comment #1)
> There is no XMLHttpRequest and no dependency on the network connection AFAICT.
> This link simply calls InstallTrigger - does it attempt to connect before
> showing the dialog?

I read that there was an XMLHttpRequest in some other bug but I don't know. Anyway, what's important is it does attempt to connect before showing the dialog.

Comment 3

[Mike Shaver (:shaver emeritus)]

This sounds like something that installTrigger should do -- and would have to: the page can't tell when the installTrigger dialog has been put up.

Comment 4

[Dave Townsend [:mossop]]

This is part of XPInstall, it pulls down part of the xpi to check if it is signed before displaying the install dialog I believe.

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> This is part of XPInstall, it pulls down part of the xpi to check if it is
> signed before displaying the install dialog I believe.
That is correct... Thanks Dave