37532 - asserts clicking on javascript hrefs

Status: VERIFIED DUPLICATE of bug 40160

(Core :: DOM: Navigation, defect, P3)

Description

[sean echevarria]

http://lxr.mozilla.org/seamonkey/source/webshell/src/nsWebShell.cpp#1206 
recently changed from:

rv = aURL->GetHost(getter_Copies(host));
if (NS_FAILED(rv)) return rv;

to:

NS_ENSURE_SUCCESS(aURL->GetHost(getter_Copies(host)), NS_ERROR_FAILURE);

This causes asserts when aURL->scheme is 'javascript'.  For example, clicking 
on the following causes an assert:

<a href="javascript://"	onClick="alert('assert');">Some link</a>

Should javascript schemes have a host?  If not, please restore the old code.  
Otherwise there are other problems.

Comment 1

[Judson Valeski]

warren, should we ditch the ensure success, or should js urls succeed on this
call?

Comment 2

[Warren Harris]

I don't know. Isn't this mscott's thing?

Comment 3

[Scott MacGregor]

I have a fix for this it just isn't nsbeta2...


*** This bug has been marked as a duplicate of 40160 ***

Comment 4

[Stephen Walker]

verifying