375320 - XForms leaks

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: possible patch

Load https://bugzilla.mozilla.org/attachment.cgi?id=259377
and you'll see some leaks.

I think we can clear most things when unload event is handled.
The changes to nsXFormsControlListItem::FindControl are needed because
mControlListHash->Get addrefs.
http://lxr.mozilla.org/seamonkey/source/xpcom/glue/nsRefPtrHashtable.h#63

Comment 1

[aaronr]

Comment on attachment 259629 [details] [diff] [review]
possible patch

Excellent catch Olli!

We already do most of the clearing that you added to HandleUnload during OnDestroyed.  I see the value in doing the clearing earlier and that we still need the code in OnDestroyed in case the model is removed from the document prior to unload being fired (i.e. due to DOM manipulation), but you should comment the changes in HandleUnload to make that clear why we are clearing that information here as well as OnDestroyed so someone won't think that we accidentally duplicated the code and remove it later.

with that, r=me

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 259629 [details] [diff] [review]
possible patch

I'll add that comment.

Comment 3

[aaronr]

checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16