Closed Bug 375481 Opened 17 years ago Closed 17 years ago

[places] unable to dnd bookmarks to the personal toolbar

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: moco, Assigned: moco)

Details

(Keywords: regression)

Attachments

(1 file)

[places] unable to dnd bookmarks to the personal toolbar

I'm using my own Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070326 Minefield/3.0a4pre.

when I dnd the favicon from the url bar, the "I" shappend drop cursor stays after I drop (but the bookmark is not added)

when I dnd from a link in the page, the cursor does not persist after I drop, but the bookmark isn't added, either.

the last thing in the console is:

*** PlacesCreateItemTransaction(https://bugzilla.mozilla.org/enter_bug.cgi?produ
ct=Firefox, 4, -1)

in the error console, I see 

Error: TYPE_X_MOZ_URL is not defined
Source File: chrome://browser/content/places/utils.js
Line: 662

hmm, that should be this.TYPE_X_MOZ_URL maybe?
Attached patch one line fixSplinter Review
Assignee: nobody → sspitzer
Status: NEW → ASSIGNED
Attachment #259750 - Flags: review?(mano)
Comment on attachment 259750 [details] [diff] [review]
one line fix

r=mano
Attachment #259750 - Flags: review?(mano) → review+
fixed.

Checking in content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.26; previous revision: 1.25
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: