375505 - Metal Lion - Vista updated version 1.6.2 theme not replacing the 1.5 version

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Frank Lion]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070314 BonEcho/2.0.0.3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070314 BonEcho/2.0.0.3pre ID:2007031404

Metal Lion - Vista updated version 1.6.2 theme not showing on Addons on frontpage links. The ML-V 1.5 version is. Both versions are available for installation.

Reproducible: Always

Steps to Reproduce:
1.Go to Addons frontpage Theme listings
2.
3.
Actual Results:  
Version 1.5 of ML-V showing and linking to https://addons.mozilla.org/en-US/firefox/addon/4325.

Expected Results:  
Expect to see the newly updated Metal Lion - Vista version 1.6.2 there and linking to https://addons.mozilla.org/en-US/firefox/addon/4626

There are two Public versions of the theme, Metal Lion -Vista on the Public Addons site -

version 1.5  https://addons.mozilla.org/en-US/firefox/addon/4325
..and the new version 1.6.2 https://addons.mozilla.org/en-US/firefox/addon/4626

As expected, both have the same GUID

GUID: {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
GUID: {1AF3FC34-0725-4485-A939-6B40EB7CA96A} 

The 1.6.2 version was reviewed and approved about 10 days ago (?) and should replace the 1.5 version. It does appear on the newly updated list.

Thanks.

Comment 1

[Frank Lion]

I forgot to add that, Firefox with Metal Lion-Vista 1.5 installed is showing a 'No available updates' message, when 'Find Updates' is selected. This is more important than the listing link, but obviously both would get fixed together.

Sorry not to have put this part in first - I was on wrong page of notes! 

Comment 2

[Frank Lion]

I know, from talking to morgamic, that version 1.6.2 is now updating wnen 'Find Updates' is selected. This is a big problem solved.

However, there are, er, still 2 versions of ML-V on Addons (1.5 and 1.6.2) and the frontpage one is, unfortunately, the 1.5 one. Could I have a progress report on this and, in particular, is there anything that you would like me to do on this one, at my end?

Comment 3

[Frank Lion]

Status changed.

I now want to bring out a new version of Metal Lion - Vista, but...we now have the situation, after 2 weeks since this bug was submitted, that - https://addons.mozilla.org/en-US/firefox/browse/type:2/cat:all/sort:popular?page=2

...both versions 1.5 and 1.6.2 are showing on the same page! with the total downloads figures being shared between the two versions, i.e the theme is showing much lower down those lists than it should be. In addition, I have no idea what to do about the new version, because no one is telling me anything here.

Deleting the 1.5 version would also, obviously, delete also the entire version history and previous versions, etc.

Comment 4

[Frank Lion]

I see that a 'Depends on ' Bug 377173 has now been added. Until this is fixed, why not temporarily disable version 1.5? It has a history of just under 1,000,000 downloads, so obviously it would be silly to disable it permanently. Perhaps a link to the correct version could also be put onto the page.

That way, at least, there would only be one downloadable version on Addons. When bug 377173 is fixed then version 1.5 (and the previous versions) could be added back onto the 1.6.2+ history.

A reply to this post, would be good.

Frank :)

Comment 5

[Justin Scott [:fligtar]]

Prior to version 1.6.2, your GUID in install.rdf was:

<em:id>{1AF3FC34-0725-4485-A939-6B40EB7CA96A}
</em:id>

in 1.6.2, you removed the line break:
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>

which counted as a different GUID in v2.

+------+------------------------------------------+
| id   | guid                                     |
+------+------------------------------------------+
| 4325 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
 |
| 4361 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
 |
| 4446 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
 |
| 4447 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
 |
| 4509 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}
 |
| 4626 | {1AF3FC34-0725-4485-A939-6B40EB7CA96A}   |
+------+------------------------------------------+
6 rows in set (0.02 sec)

In order to keep your original ID, you will either need to go back to the GUID you originally used with the line break, or we can remove the line break for unknown results with updating.

Comment 6

[Frank Lion]

I am aware of all this, Justin. Morgamic and I discussed it all at the time. It is not possible to go back to a GUID with a line break as Remora does not accept this a valid, as pre-Remora did (which is how the situation arose). 

Regarding 'or we can remove the line break for unknown results with updating'. Please do this with one of your themes, not one of mine.

What about my suggestion of a temporary disabling of version 1.5?

Comment 7

[Frank Lion]

For your records, versions 1.1 and 1.3 both had single line GUIDs, i.e. the normal way of having them. Something happened to versions 1.4 and 1.5 and a line break appeared at the end of the GUID line.

This is the line break that Addons Remora does not accept when in the Dev Control panel, updating to a new version.

Comment 8

[Frank Lion]

Changed resolution to FIXED.