375509 - No 'Add To Calendar' button in TB 1.5 when I get a mail with a attached *.ics-file

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Andreas Treumann]

REPRODUCTION:
=============

- Use Thunderbird 1.5.0.10 with the latest nightly build
- Go to your mail account and open a mail with a attached ics file from an event invitation

RESULT:
=======

- You get no 'Add To Calendar' button

Output JavaScript Console:

Error: convertToHTML: Cannot create itipItem: TypeError: this.mUri has no properties
Source File: file:///export/home/pim01/.thunderbird/u4fckqom.com_nightly/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/lightningTextCalendarConverter.js
Line: 178

EXPECTED RESULT:
================

- The 'Add To Calendar' button is visible

REPRODUCIBLE:
=============

- always


Same test case with Thunderbird 2.0 beta 2 works.

Comment 1

[Matthew (lilmatt) Willis]

Over to Clint.

We could also consider dropping Tb 1.5 support once Tb 2 is out.

Comment 2

[Matthew (lilmatt) Willis]

Attempting this with the latest Lightning nightly and Tb 1.5.0.10 on Mac I get:

Error: [Exception... "Component returned failure code: 0x804a0100 [calIICSService.parseICS]"  nsresult: "0x804a0100 (<unknown>)"  location: "JS frame :: file:///Users/lilmatt/Library/Thunderbird/Profiles/q9oojaug.1.5test/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calItemBase.js :: icalFromString :: line 775"  data: no]
Source File: file:///Users/lilmatt/Library/Thunderbird/Profiles/q9oojaug.1.5test/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calItemBase.js
Line: 775

Comment 3

[Matt Foster]

I'm having this same issue...also on TB 1.5.0.10 on WinXP Pro.  What I find interesting is that the message pane appears completely blank on the copy I get from the originator.  However, if I have someone else who has received the invitation forward me a copy, then it shows up complete with the "Add To Calendar" button.

Comment 4

[cmtalbert]

Attachment: This fixes the code to work on thunderbird 1.5.10

There is still a matter of style.  The style we inherit from for the buttons has changed from 1.5.10 to 2.0.x.  We worked hard on the style so that it looks right in 2.0.x, but that has caused the buttons to shift right a little bit in Thunderbird 1.5.10.

That can be addressed in a following patch, if we decide it's worth addressing at this point.  I'll paste a screen shot of the issue.

Comment 5

[cmtalbert]

Attachment: Screen shot of imip bar on Thunderbird 1.5.10 on Windows

This shows the button shifting issue, on Tbird 1.5.10.

On Thunderbird 2.0.x the buttons are OK.

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 261292 [details] [diff] [review]
This fixes the code to work on thunderbird 1.5.10

Add a comment to the else block in imip-bar.js explaining it's the Tb1.5 case.

r=lilmatt with that

Comment 7

[cmtalbert]

Fix checked in on branch and trunk. --> Fixed

Comment 8

[Andreas Treumann]

I checked this issue with the latest nightly build (2007041503) -> task is fixed and verified.

Comment 9

[Stefan Sitter [:ssitter]]

(In reply to comment #5)
> Screen shot of imip bar on Thunderbird 1.5.10 on Windows

FYI: I see the same button text shifting issue using Lightning/0.5pre (2007041604) with Thunderbird 2.0.0.0pre (20070416) on Windows 2000.

Comment 10

[6e77a 70 6e 6e7a]

I just tried out 2007042304 with Thunderbird 1.5.0.10 on Windows. I'm still getting a blank message. Am I doing something wrong?

Comment 11

[cmtalbert]

(In reply to comment #10)
> I just tried out 2007042304 with Thunderbird 1.5.0.10 on Windows. I'm still
> getting a blank message. Am I doing something wrong?
> 

Hello, we have not seen this.  Can you forward the invitation that is broken to my email so that I can try it out?  Please send to [e-mail].  Thanks!

Comment 12

[6e77a 70 6e 6e7a]

I just now forwarded an anonymized invitation to you by email.

Comment 13

[6e77a 70 6e 6e7a]

Were you able to reproduce the problem?