Closed
Bug 375602
Opened 18 years ago
Closed 18 years ago
makedocs.pl --with-pdf parameter check is buggy
Categories
(Bugzilla :: Documentation, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bugzilla-mozilla, Assigned: bugzilla-mozilla)
Details
Attachments
(1 file)
|
568 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
The grep used by makedocs.pl to check for --with-pdf is buggy.
Example:
$ ./makedocs.pl --help
[..]
Creating PDF documentation ...
Expected a usage screen. But as that is not implemented, it still should not build PDF stuff without giving --with-pdf.
Attachment #259834 -
Flags: review?
|
||
Comment 1•18 years ago
|
||
Comment on attachment 259834 [details] [diff] [review]
Patch v1
Nice catch. r=LpSolit
Attachment #259834 -
Flags: review? → review+
|
|
||
Comment 2•18 years ago
|
||
This is related to documentation only, so we can take it on all branches.
Assignee: documentation → bugzilla-mozilla
Flags: approval3.0+
Flags: approval2.22+
Flags: approval2.20+
Flags: approval2.18+
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
Version: 3.1 → 2.18.6
|
|
||
Comment 3•18 years ago
|
||
tip:
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.17; previous revision: 1.16
done
3.0 RC1:
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.16.2.1; previous revision: 1.16
done
2.22.2:
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.10.2.1; previous revision: 1.10
done
2.20.4:
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.7.10.1; previous revision: 1.7
done
2.18.6:
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.7.2.1; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•