375606 - Airbag won't build on debug trunk

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[aaronr]

I get the following error building a debug firefox trunk:

link -NOLOGO -OUT:crashreporter.exe -PDB:crashreporter.pdb -SUBSYSTEM:WINDOWS -DEBUG -DEBUGTYPE:CV       crashreporter_win.obj ./module.res ../../../toolkit/airbag/airbag/src/client/windows/sender/crash_report_sender.lib ../../../toolkit/airbag/airbag/src/common/windows/airbag_common_s.lib  kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib comctl32.lib shell32.lib wininet.lib MSVCRTD.lib(crtexew.obj) : error LNK2019: unresolved external symbol _WinMain@16 referenced in function ___tmainCRTStartup
crashreporter.exe : fatal error LNK1120: 1 unresolved externals

I now know that I can get around this by disabling airbag in my .mozconfig, but this should still probably be addressed.  I assume that this is caused by the fact that WinMain isn't compiled in on debug yet the subsytem linker flag is still saying 'WINDOWS'.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: remove the debug check

Whoops, my bad.  I copied that bit from updater.cpp, but neglected to copy the Makefile bits as well:
http://mxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/updater/Makefile.in#97

I'm going to just remove the DEBUG check, since having a console on the crash reporter isn't terribly useful anyway.

Comment 2

[Axel Hecht]

Comment on attachment 259885 [details] [diff] [review]
remove the debug check

Looks good to me, and I just hit that problem, too.

Comment 3

[(not currently active) Ted Mielczarek]

Fix checked in, sorry about that.

Comment 4

[Axel Hecht]

VERIFIED, just tested on my debug build with VC express and mozilla-build.