Last Comment Bug 375754 - regression: submission replace instance with method=post broken
: regression: submission replace instance with method=post broken
Status: RESOLVED FIXED
: fixed1.8.0.12, fixed1.8.1.4
Product: Core Graveyard
Classification: Graveyard
Component: XForms (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: ---
Assigned To: aaronr
: Stephen Pride
Mentors:
Depends on:
Blocks: 353738
  Show dependency treegraph
 
Reported: 2007-03-28 14:48 PDT by aaronr
Modified: 2016-07-15 14:46 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (5.07 KB, patch)
2007-03-28 14:49 PDT, aaronr
bugs: review+
doronr: review+
Details | Diff | Splinter Review

Description aaronr 2007-03-28 14:48:25 PDT
Looks like I regressed submission with my patch for bug 357901.

There is a comment in the code that SetUploadStream will set the request header to have method 'put', but I completely missed that when I moved the post submission logic to execute sooner in the ::SendData method.  I did that since we already had the httpChannel at that point.

To fix this regression, I moved the code back to after the call to SetUploadStream and moved the httpChannel variable out in scope so that it can be used later, too, without having to do another QI.
Comment 1 aaronr 2007-03-28 14:49:11 PDT
Created attachment 259953 [details] [diff] [review]
patch
Comment 2 aaronr 2007-03-28 15:34:48 PDT
checked into trunk
Comment 3 aaronr 2007-04-23 16:28:50 PDT
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16

Note You need to log in before you can comment on or make changes to this bug.