375790 - rebuildcvshistory doesn't properly deal with files in the Attic

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Bonsai, defect)

Description

[Dave Miller [:justdave]]

If a file is in the Attic when you run rebuildcvshistory, it gets inserted into the database with Attic in its path.  Changes to this file are all handled without Attic in the path, so you wind up with two copies of it in the database.

The case we noticed tonight, files were committed then later deleted. They're in the database at the normal path.  cvsrebuildhistory was run, and additional entries for those files in the attic were added instead of modifying the existing ones.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=mozilla%2Fbrowser%2Ffuel&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=all&mindate=&maxdate=&cvsroot=%2Fcvsroot

Comment 1

[Dave Miller [:justdave]]

a proper fix for this will need some way to clean up the existing corruption as well (even if it's a separate script to run once to do it).

Comment 2

[Dave Miller [:justdave]]

You can see another instance of this in action on bug 421018.

Comment 3

[Dave Miller [:justdave]]

And another one in bug 423986.

Comment 4

[Adam Muntner [:adamm] (use NEEDINFO)]

Bonsai was decommissioned, closing all remaining bugs "wontfix"