Closed Bug 375818 Opened 17 years ago Closed 17 years ago

Review search and RSS for Ukrainian

Categories

(Mozilla Localizations :: uk / Ukrainian, defect)

Product:
Mozilla Localizations
Component:
uk / Ukrainian
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

Attachments

(1 file, 3 obsolete files)

only 2 first places on searh engine list defined
1.22 KB, patch
Pike
: review+
Details | Diff | Splinter Review 
Mic, the search engine list for Ukrainian is

google
lingvo.yandex.ru
yahoo-ru
yandex

with Google on first, Yandex on second. This is close to the russian search setup, though not the same thing.

RSS readers are Bloglines, Google, My Yahoo.

Tim, are there any suggestions you would have that are really Ukrainian? Wikipedia has some 55k articles, that sounds reasonable. Others?
Tim, have you considered Netvibes.com as a feed handler? It's available in Russian and other languages (and they're open for new localizations, so there might be a Ukrainian version).
I've just checked Netvibes.com and it has a Ukrainian version. 

I've also posted to .l10n about having Netvibes in more locales.
Hi Tim,
on search engine's per Axel's comment about any other Ukranian search engine's I did a bit of research and found these two (see below). I can't really tell if they're any good but we're open to adding local search engine's that offer content in Ukranian or give the users a better searching experience for Ukranian sites. Here's the two I found, I look forward to your thoughts:
http://www.uazone.net/sesna/
http://meta.ua/ 

Also checked out Wikipedia Ukranian and that seems good too, if you agree.
Best
mic
Hi Mic, meta.ua is a well-known brand, while "sesna" is unknown site that redirects to another site that actually uses Google for searching.

There is statistics on search engine usage held by one of the top Ukrainian portals. According to it Ukrainian users rank search engines in 2007 this way:

google.com  	80`582`050  	60.9
yandex.ru 	21`016`577 	15.9
meta.ua 	9`450`212 	7.1
rambler.ru 	9`376`935 	7.1
bigmir.net 	8`097`012 	6.1
http://index.bigmir.net/se?y=2

In addition to those I think we should add uk.wikipedia
and price.ua - top rated price aggregator.
For RSS readers Netvibes(best and translated), Yandex.Lenta(Russian, popular too), Google.Reader(through untranslated) would be good to go.
Bigmir is not needed, as it has no search engine, just uses Yandex.
Hi Tim,

so for search engine's are you concluded on:
google.com
yandex.ru
meta.ua
rambler.ru
uk.wikipedia
price.ua

and for RSS readers:
Netvibes
Yandex.Lenta
Google.Reader

Please confirm, this seems reasonable to me so you'd have approval to go ahead. I look forward to your comments
Mic

Yes, I propose we use those you listed.
great, lmk when it's implemented so I can verify and we can keep moving forward :)
Searchengines are in.
Mic, please take a look. Also I kept Bloglines and My.Yahoo just in case someone need them.
Tim
it appears from Axel's verifier tool that your search plug-in's are right but I can't tell about the RSS feeds so I need to check in with Axel (tomorrow, too late now due to time difference so he's not online) on how to check those. Downloading the language pack doesn't allow me to verify these settings.
so, OK on search plug-ins and I'll get back to you on RSS
thanks
mic

Hi
i've checked the build exe file you sent and here are some questions:
the RSS readers, there's one additional one that's there you hadn't mentioned and is therefore unauthorized: yandex. not sure why that's there. also if netvibes provides a ukranian version should we list it first? finally the typical order for rss readers is my yahoo, igoogle and bloglines or netvibes (depending).
in terms of search i noticed that the order is not what we proposed, again i'm not sure if that was intentional or not. i saw:
google, yandex.ru, meta,ua, price.ua, rambler.ru adn then uk.wikipedia.
Finally, the installer didn't seem to look right. the language wasn't reading properly, this could be because I didn't have a uni-8 installed properly. i'm not sure.
thanks
mic

oops, see that i did approve yandex reader in comment#7. i should have checked about this first.
do we have approval from yandex to use their reader and are you proposing this one cause it's better than the others?
thanks
mic

For Yandex approval, see the Russian bug 351928 comment 11.

Hello Mic. I updated ordering to be exact as we agreed before, those were just minor misses. I still prefer Netvibes to Yandex because of it's Ukrainian interface. 

As for build, it runs fine on windows boxes I used. May be you just had no necessary font...
r-, you changed the default search and the first engine from Google to Netvibes.

tim.babych%gmail.com:  -browser.search.defaultenginename = Google
tim.babych%gmail.com:  -browser.search.order.1 = Google
tim.babych%gmail.com:  +browser.search.defaultenginename = Netvibes
tim.babych%gmail.com:  +browser.search.order.1 = Netvibes

That part shouldn't have happened. Tim, could you attach a patch for your next attempt to fix this and request review from me on it? Then we don't have to iterate over this in CVS.
Attached patch restored Google on first place (obsolete) — — Splinter Review 
Sorry. Attached updated region.properties for review.
Attachment #271667 - Attachment is patch: true
Attachment #271667 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 271667 [details] [diff] [review]
restored Google on first place

Could you create a patch instead? Let's try this to the full extent, you'll need this on the branch, anyway. The file looks good, though.

You create a patch with 

cvs -z3 diff -u

in your localization directory. That will show the changes on stdout, and you can redirect that into a file with

cvs -z3 diff -u > ../some/file

I wrote some stub doc on http://developer.mozilla.org/en/docs/Patching_a_Localization#Creating_a_patch, I'm interested if that's useful.

Then you attach the patch file to bugzilla. Make sure to check the patch-checkbox. You may want to get attention on the patch, in our case, you'd want my review, so while attaching the patch, you'd set the r flag (via the dropdown) to '?'.

The reviewer then signals a positive review by changing that flag to '+', and a negative review by setting it to '-'. The latter means that there's more work to be done. Just like I just did.
Attachment #271667 - Flags: review-
Thanks for a hints, they could have saved me great deal of time when I was wandering from what repo and what branch to checkout. Testing section is missing but you are probably already aware of that.
Attachment #271667 - Attachment is obsolete: true
Attachment #271673 - Flags: review?
Comment on attachment 271673 [details] [diff] [review]
patch to move Google back to first place

From the patch/attachement work, this is good. The content is not, sadly.

>? feeds.patch
>Index: browser/chrome/browser-region/region.properties
...
>+browser.search.order.2 = Netvibes

Netvibes is not a search, so this is clearly wrong.

Mic, Tim, we should clarify on whether yandex is supposed to be second, or just in there.

Tim, any opinion on that?
Attachment #271673 - Flags: review? → review-
ordering of search engines and feed handlers as stated in comment #7
Attachment #271673 - Attachment is obsolete: true
Attachment #271680 - Flags: review?
Hi
order of search engine's 
Tim I thought you wanted Yandex second because users use it quite a bit? therefore I ordered it second. Otherwise the balance of the order should follow alphabetical unless there's a use case for it to be otherwise. Tim, is there a use case for a different approach here?
here's the policy on search order for reference:
http://wiki.mozilla.org/Firefox3/L10n_Requirements#Search_Order
which is new from Firefox 2 implementations where the order didn't follow any particular approach.

order of RSS readers is fine based on use case for Ukranian, meaning Netvibes is better than the other options and available in your language.

make sense?
mic

>Tim I thought you wanted Yandex second because users use it quite a bit?

Yes, exactly. And you saw it on second place in comment #13 yourself and I am happy with it. That comment confused me a bit with requirements to make all six engines appear exactly as defined... Through I do not really care about exact ordering of less-significant SE's, so that latest patch that brings back just two gorillas(1:Google, 2:Yandex) should be fine.
Attachment #271680 - Attachment is obsolete: true
Attachment #271702 - Flags: review?
Attachment #271680 - Flags: review?
Comment on attachment 271702 [details] [diff] [review]
only 2 first places on searh engine list defined

This is the patch I expected :-), r=me.

Tim, it'd be a good idea to  make a rich check-in comment. Something like "bug 375818, fix Ukrainian search and RSS readers, r=l10n@mozilla.com" would be good.

In general, mentioning bugs and review on the trunk is not required, but for the branch, it will be (it'd be approval there, but still). And for the productization files like region.properties, you should always have a bug to track changes, and mic and me on the hook. I'll do the sign-off on the technical implementation of what Mic says, thus the r=l10n@mozilla.com.
Attachment #271702 - Flags: review? → review+
committed. 
Mic, please take a look at recent build, http://l10n.mozilla.org/~buildslave/incubator/ both search engines and rss readers appear to me exactly as they should be.
Hi Tim
will do. I'm having trouble with my current o/s for this so I'll have to do this later tonight/tmo. will get back to you asap
mic

Hi
thanks for your help in testing.
I've tested and verify search and rss specifications are accurate/correct.
mic

to be clear, it's verified with me, over to you Axel on any other aspects otherwise I think we're good to close this bug
mic

Marking this bug FIXED, then. Bug 398596 has been filed to get a new feed up, but that's not really blocking.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: