Incorrect parameter passing in nsCSSRendering.cpp

RESOLVED FIXED

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Jeremy Lea, Unassigned)

Tracking

unspecified
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070329 Minefield/3.0a4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070329 Minefield/3.0a4pre

Several calls to DrawSolidBorderSegment have a PRBool as the third arguments, when it takes appUnitsPerPixel (which is incorrectly named twipsPerPixel).  Patch in a second.

Reproducible: Always
(Reporter)

Comment 1

11 years ago
Created attachment 260079 [details] [diff] [review]
Simple fix.

Simple fix.  Unless someone was trying to be really creative...  But then there should be a comment, and PR_TRUE/PR_FALSE shouldn't be used...
Attachment #260079 - Flags: review?(roc)
This code is in the midst of being rewritten, but we'll take this!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #260079 - Flags: superreview+
Attachment #260079 - Flags: review?(roc)
Attachment #260079 - Flags: review+
checked in
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
It seems like this bug ought to have exhibited itself in actual testcases.
Flags: in-testsuite?
(Reporter)

Comment 5

11 years ago
(In reply to comment #4)
> It seems like this bug ought to have exhibited itself in actual testcases.
> 

I think this would have only resulted in the code taking a slow path.  I don't fully understand it, but it looked like it was just testing to see if the segment was smaller than a pixel and if it was, just draw a block.  The incorrect parameters would have caused those tests to fail.
You need to log in before you can comment on or make changes to this bug.