Closed Bug 375984 Opened 17 years ago Closed 17 years ago

"Allow messages to use other fonts" checkbox is in the wrong place

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: rod.whiteley, Assigned: philor)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Thunderbird 2.0.0.0 (20070326)

The UI makes you think "Allow messages to use other fonts" is set per language group, but in reality there is only one pref: browser.display.use_document_fonts

Reproducible: Always

Steps to Reproduce:
1. Choose Tools - Options - Display - Formatting - Fonts... to open the Fonts & Encodings dialog
Actual Results:  
The checkbox "Allow messages to use other fonts" is inside the groupbox for language groups.

Expected Results:  
The checkbox should be outside the groupbox (perhaps just below it).
Attached patch Get groovy v.1Splinter Review
A separate groupbox is probably too much: that tends to mean that the only connection between the groups is that they live on the same pane, not that one affects how the other is applied. Borrowing Firefox's visible separator ought to be enough, though it looks better to me with a thin separator above for space, rather than Fx's full separator.

I thought about borrowing Fx's explicit "Allow __ to choose their own fonts, instead of my selections above" string, too, but I'm not sure it's really needed.
Assignee: mscott → philringnalda
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #260208 - Flags: review?(mscott)
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → Thunderbird 3
Version: unspecified → Trunk
Attached image Obligatory screenshot
That proposal shows the checkbox as somewhat separate but still within the scope of the "Fonts for" choice, and therefore still misleading.  It does not fix this bug.
Attachment #260208 - Flags: review?(mscott) → review+
mail/components/preferences/fonts.xul: 1.11
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: