Last Comment Bug 376042 - rename nsIFrame::GetPresContext to PresContext
: rename nsIFrame::GetPresContext to PresContext
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: (dormant account)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-30 14:08 PDT by (dormant account)
Modified: 2007-04-26 13:22 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Automatic patch produced in debug configuration on linux/osx + manual step for windows (217.83 KB, patch)
2007-03-30 14:08 PDT, (dormant account)
no flags Details | Diff | Splinter Review

Description (dormant account) 2007-03-30 14:08:29 PDT
Created attachment 260180 [details] [diff] [review]
Automatic patch produced in debug configuration on linux/osx + manual step for windows
Comment 1 Boris Zbarsky [:bz] 2007-03-30 15:13:35 PDT
Checked in.
Comment 2 Boris Zbarsky [:bz] 2007-04-25 18:32:31 PDT
taras, I was wondering whether we could fix up situations like:

  foo->GetPresShell()->Foo(barArg,
                           bazArg);

so they don't end up like:

  foo->PresShell()->Foo(barArg,
                           bazArg);

and instead up as:

  foo->PresShell()->Foo(barArg,
                        bazArg);

?
Comment 3 (dormant account) 2007-04-26 13:17:42 PDT
Boris,
Right now I'm pushing the limits of what oink can do without producing extremely ugly source code.
I think what you want is a good pretty printer for C++, with proper indentation. That's already on the TODO list, but there are a few higher priority items before that.
Comment 4 Boris Zbarsky [:bz] 2007-04-26 13:22:23 PDT
Sure.  It's not urgent; I just ended up doing a lot of indent-fixing when I had to touch some presshell functions recently, so I was wondering whether we could have avoided it easily.  If not, then so be it.

Note You need to log in before you can comment on or make changes to this bug.