376042 - rename nsIFrame::GetPresContext to PresContext

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(dormant account)]

Attachment: Automatic patch produced in debug configuration on linux/osx + manual step for windows

Comment 1

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 2

[Boris Zbarsky [:bzbarsky]]

taras, I was wondering whether we could fix up situations like:

  foo->GetPresShell()->Foo(barArg,
                           bazArg);

so they don't end up like:

  foo->PresShell()->Foo(barArg,
                           bazArg);

and instead up as:

  foo->PresShell()->Foo(barArg,
                        bazArg);

?

Comment 3

[(dormant account)]

Boris,
Right now I'm pushing the limits of what oink can do without producing extremely ugly source code.
I think what you want is a good pretty printer for C++, with proper indentation. That's already on the TODO list, but there are a few higher priority items before that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sure.  It's not urgent; I just ended up doing a lot of indent-fixing when I had to touch some presshell functions recently, so I was wondering whether we could have avoided it easily.  If not, then so be it.