Closed Bug 376046 Opened 14 years ago Closed 14 years ago

add support for specifying an ssh private key in the symbol upload script

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file, 4 obsolete files)

Apparently the windows tinderbox needs to specify an SSH private key in the ssh command line.  I'll add another env var that the upload script will optionally use to point to a private key.
We may not need this, this should be doable in ~/.ssh/config.
Blocks: 376063
Add the env var, plus some env var renaming.  I also tweaked tinder-defaults.pl to match.
Attachment #260446 - Flags: first-review?(benjamin)
Attached patch same as before (obsolete) — Splinter Review
Just realized that some of my entries in tinder-defaults didn't have trailing semicolons.  At least they were commented out!
Attachment #260446 - Attachment is obsolete: true
Attachment #260447 - Flags: first-review?(benjamin)
Attachment #260446 - Flags: first-review?(benjamin)
Attachment #260447 - Flags: first-review?(benjamin) → first-review+
Checked in on trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Use the correct bashism, rev. 1 (obsolete) — Splinter Review
Attachment #260605 - Flags: first-review?(ted.mielczarek)
Attached patch correct bash-fu (obsolete) — Splinter Review
Right, I totally tested with the correct bashism and then wrote the wrong thing in the patch.  D'oh!
Attachment #260447 - Attachment is obsolete: true
Attachment #260605 - Attachment is obsolete: true
Attachment #260614 - Flags: first-review?(benjamin)
Attachment #260605 - Flags: first-review?(ted.mielczarek)
Ugh, looking at the log it wouldn't have worked even with that fix, cause I missed a line in my renaming in an earlier patch.  This fixes both.
Attachment #260614 - Attachment is obsolete: true
Attachment #260615 - Flags: first-review?(benjamin)
Attachment #260614 - Flags: first-review?(benjamin)
Attachment #260615 - Flags: first-review?(benjamin) → first-review+
Changed to #!/bin/bash in the script and checked in.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.