add support for specifying an ssh private key in the symbol upload script

RESOLVED FIXED

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

11 years ago
Apparently the windows tinderbox needs to specify an SSH private key in the ssh command line.  I'll add another env var that the upload script will optionally use to point to a private key.
(Assignee)

Comment 1

11 years ago
We may not need this, this should be doable in ~/.ssh/config.
(Assignee)

Updated

11 years ago
Blocks: 376063
(Assignee)

Comment 2

11 years ago
Created attachment 260446 [details] [diff] [review]
add optional environment variable for ssh private key

Add the env var, plus some env var renaming.  I also tweaked tinder-defaults.pl to match.
Attachment #260446 - Flags: first-review?(benjamin)
(Assignee)

Comment 3

11 years ago
Created attachment 260447 [details] [diff] [review]
same as before

Just realized that some of my entries in tinder-defaults didn't have trailing semicolons.  At least they were commented out!
Attachment #260446 - Attachment is obsolete: true
Attachment #260447 - Flags: first-review?(benjamin)
Attachment #260446 - Flags: first-review?(benjamin)

Updated

11 years ago
Attachment #260447 - Flags: first-review?(benjamin) → first-review+
(Assignee)

Comment 4

11 years ago
Checked in on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

11 years ago
Created attachment 260605 [details] [diff] [review]
Use the correct bashism, rev. 1
Attachment #260605 - Flags: first-review?(ted.mielczarek)
(Assignee)

Comment 6

11 years ago
Created attachment 260614 [details] [diff] [review]
correct bash-fu

Right, I totally tested with the correct bashism and then wrote the wrong thing in the patch.  D'oh!
Attachment #260447 - Attachment is obsolete: true
Attachment #260605 - Attachment is obsolete: true
Attachment #260614 - Flags: first-review?(benjamin)
Attachment #260605 - Flags: first-review?(ted.mielczarek)
(Assignee)

Comment 7

11 years ago
Created attachment 260615 [details] [diff] [review]
bash-fu + a bonus fix that i missed in a previous patch

Ugh, looking at the log it wouldn't have worked even with that fix, cause I missed a line in my renaming in an earlier patch.  This fixes both.
Attachment #260614 - Attachment is obsolete: true
Attachment #260615 - Flags: first-review?(benjamin)
Attachment #260614 - Flags: first-review?(benjamin)

Updated

11 years ago
Attachment #260615 - Flags: first-review?(benjamin) → first-review+
(Assignee)

Comment 8

11 years ago
Changed to #!/bin/bash in the script and checked in.
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.