376046 - add support for specifying an ssh private key in the symbol upload script

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Apparently the windows tinderbox needs to specify an SSH private key in the ssh command line.  I'll add another env var that the upload script will optionally use to point to a private key.

Comment 1

[(not currently active) Ted Mielczarek]

We may not need this, this should be doable in ~/.ssh/config.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: add optional environment variable for ssh private key

Add the env var, plus some env var renaming.  I also tweaked tinder-defaults.pl to match.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: same as before

Just realized that some of my entries in tinder-defaults didn't have trailing semicolons.  At least they were commented out!

Comment 4

[(not currently active) Ted Mielczarek]

Checked in on trunk.

Comment 5

[Benjamin Smedberg]

Attachment: Use the correct bashism, rev. 1

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: correct bash-fu

Right, I totally tested with the correct bashism and then wrote the wrong thing in the patch.  D'oh!

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: bash-fu + a bonus fix that i missed in a previous patch

Ugh, looking at the log it wouldn't have worked even with that fix, cause I missed a line in my renaming in an earlier patch.  This fixes both.

Comment 8

[(not currently active) Ted Mielczarek]

Changed to #!/bin/bash in the script and checked in.