37632 - nsHTTPHandler::PrefsChanged uses different preferences types from initial preferences file

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Chris Siebenmann]

Build: current CVS tip.

 nsHTTPHandler::PrefsChanged disagrees about the types of several
preferences with modules/libpref/src/init/all.js. PrefsChanged uses
GetIntPref() for several that the normal all.js file has set up as
boolean preferences (PrefsChanged uses 0 for false and 1 for true).

 The ones I can see are network.http.keep-alive,
network.http.proxy.keep-alive, network.http.pipelining, and
network.http.proxy.pipelining.

 The effect of this disagreement is to render it impossible for
the user to set preferences for any of those variables in their
own prefs.js file.

 I am not sure whether all.js is wrong or PrefsChanged is wrong,
so I can't attach a patch. It does seem more appropriate to use
boolean preferences for these; on the other hand the code predates
the all.js preferences entries (at least in uncommented, active
form).

 ruslan is cc'd here because bonsai says he made the change to
all.js that made these preferences active with boolean values.

Comment 1

[ruslan]

-> ruslan

Comment 2

[ruslan]

-> ruslan

Comment 3

[ruslan]

Fixed

Comment 4

[Tom Everingham]

verif.