Redundant STYLE_STACK_DEPTH, STYLE_CURRENT_STACK macros

RESOLVED FIXED in mozilla1.9beta5

Status

()

Core
Canvas: 2D
P1
trivial
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Philip Taylor, Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla1.9beta5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070402 Minefield/3.0a4pre
Build Identifier: 

nsCanvasRenderingContext2D.cpp defines STYLE_STACK_DEPTH and STYLE_CURRENT_STACK, but they are never actually used anywhere (and they cause minor confusion because they make it look like the stack has a limited size when actually it doesn't). They are used in the 1.8.0 branch, but were made redundant by bug 333177 and are not used in 1.8 or trunk.

Reproducible: Always
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: helpwanted
(Assignee)

Comment 1

10 years ago
Created attachment 307374 [details] [diff] [review]
easy patch
Assignee: nobody → joe
Status: NEW → ASSIGNED
Attachment #307374 - Flags: review?(vladimir)
(Assignee)

Updated

10 years ago
Priority: -- → P1
Attachment #307374 - Flags: review?(vladimir) → review+
(Assignee)

Updated

10 years ago
Keywords: helpwanted → checkin-needed
Need approval to land.
Keywords: checkin-needed
Version: unspecified → Trunk
Comment on attachment 307374 [details] [diff] [review]
easy patch

Please re-add the checkin-needed keyword once you have approval.
Attachment #307374 - Flags: approval1.9?
Attachment #307374 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in content/canvas/src/nsCanvasRenderingContext2D.cpp;
/cvsroot/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp,v  <--  nsCanvasRenderingContext2D.cpp
new revision: 1.123; previous revision: 1.122
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
You need to log in before you can comment on or make changes to this bug.