Closed Bug 376564 Opened 17 years ago Closed 17 years ago

Incorrect decompilation for "new (eval())"

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: jruderman, Assigned: jruderman)

References

Details

(Keywords: testcase)

Attachments

(1 file)

js> function() { new (eval()) }
function () {
    new eval();
}

In contrast, if I use "g" instead of "eval", the parens are kept correctly.

jsfunfuzz.js noticed this bug because it causes a round-trip change -- "new eval()" beomes "new eval" on the next trip through the decompiler.
I'll attach a patch (similar to the patch to bug 352453).  It modifies code recently added in bug 352013.
Assignee: general → jruderman
Attached patch patchSplinter Review
Attachment #260665 - Flags: review?(brendan)
Status: NEW → ASSIGNED
Comment on attachment 260665 [details] [diff] [review]
patch

Shoulda seen this one coming -- thanks!

/be
Attachment #260665 - Flags: review?(brendan) → review+
Blocks: js1.7src
OS: Mac OS X → All
Hardware: PC → All
Patch checked in last night, 2007-04-04 20:24.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
/cvsroot/mozilla/js/tests/js1_5/decompilation/regress-376564.js,v  <--  regress-376564.js
initial revision: 1.1
Flags: in-testsuite+
verified fixed on trunk.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: