376577 - <input type="button" disabled> not rendered as disabled Aqua widget

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since the Cocoa widget rewrite, disabled <input type="button"> widgets have been drawn as gfx widgets instead of Aqua ones.

The testcase and screenshots in bug 376576 have an example.

Comment 1

[philippe (part-time)]

Actually, all buttons (type="button", type="submit", type="reset") are affected.

Comment 2

[Stuart Morgan]

Attachment: fix

The nsNativeTheme border defaults are out of sync with forms.css, so IsWidgetStyled was coming back yes even for unstyled buttons. Enabled buttons only worked because threedface and buttonface happen to be the same color in the Mac look and feel code.

Comment 3

[Josh Aas]

Comment on attachment 262345 [details] [diff] [review]
fix

Looks good, thanks! Can you please add a comment on checkin about the need to keep those values in sync with forms.css? There is a bug about getting rid of that dependency (bug 240117) but it seems that won't get fixed for gecko1.9.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 262345 [details] [diff] [review]
fix

sr=dbaron (although it seems broken that we use "outset ButtonFace" rather than using ButtonHighlight and ButtonShadow; is there a bug on that?)

Comment 5

[Josh Aas]

landed on trunk, though I didn't add my comment. will do that soon.