Closed Bug 376585 Opened 17 years ago Closed 16 years ago

[Proto] Subscription Dialog -- Searching for Calendars

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: chris.j.bugzilla, Assigned: dbo)

References

Details

(Whiteboard: [roadmap 0.8])

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Adding more than one calendar in one single step not possible. Users need to reopen the Supscription dialog for each calendar they want to add.

Reproducible: Always

Steps to Reproduce:
1. Open the Subscriptions Dialog
2. Search for a calendar, mark it
3. Search for another calendar, mark it
Actual Results:  
Only the last marked calendar gets added to the "Calendar Subscription List"

Expected Results:  
All marked calendar should be added to the "Calendar Subscription List"
Christian asked me to reassign this bug to Berend.
Assignee: nobody → Berend.Cornelius
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: Provider: WCAP → General
QA Contact: wcap-provider → general
Daniel, do we want this to block 0.7?
Flags: blocking-calendar0.7?
Ulf and I have decided that this should not block 0.7.  This can safely be fixed post-0.7
Flags: blocking-calendar0.7? → blocking-calendar0.7-
Depends on: 370146
Depends on: 356569
Flags: wanted-calendar0.8+
Attached patch work in progress (obsolete) — Splinter Review
This is essentially Thomas' subscription UI with a few changes:
- adopted to the search API (bug 370146)
- simplified request/operation handling
- shifted from prototypes/wcap to base/content
- works for sunbird

It still has some flaws, but serves as a good start.

Berend: Please take over.
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [roadmap 0.8]
Target Milestone: --- → 0.8
Flags: blocking-calendar0.7-
This is a roadmap 0.8 item, thus blocks 0.8. Christian mentioned we should for now call the context menu "Find Calendars...".
Assignee: Berend.Cornelius → daniel.boelzle
Flags: wanted-calendar0.8+ → blocking-calendar0.8+
Attached patch patch (obsolete) — Splinter Review
Dialog and added entry to context menu of calendar list.
Attachment #286819 - Attachment is obsolete: true
Attachment #295947 - Flags: ui-review?(christian.jansen)
Attachment #295947 - Flags: review?(philipp)
Attached patch patchSplinter Review
oops, forgot to include the new files (-u8pN)...
Attachment #295947 - Attachment is obsolete: true
Attachment #295949 - Flags: ui-review?(christian.jansen)
Attachment #295949 - Flags: review?(philipp)
Attachment #295947 - Flags: ui-review?(christian.jansen)
Attachment #295947 - Flags: review?(philipp)
Comment on attachment 295949 [details] [diff] [review]
patch


>Index: calendar/base/content/calendar-subscriptions-list.xml
>+<!-- -*- Mode: xml; indent-tabs-mode: nil; -*- -->
No emacs modelines please


>Index: calendar/base/src/calCachedCalendar.js
>Index: calendar/sunbird/base/content/calendar-offline.js
These probably got in here by accident?


Otherwise it looks fine, r=philipp
Attachment #295949 - Flags: review?(philipp) → review+
Summary: [Proto] Subscription Dialog - Adding more than one calendar at once is not possible → [Proto] Subscription Dialog -- Searching for Calendars
Comment on attachment 295949 [details] [diff] [review]
patch

r=christian
Attachment #295949 - Flags: ui-review?(christian.jansen) → ui-review+
(In reply to comment #8)
> >Index: calendar/base/src/calCachedCalendar.js
> >Index: calendar/sunbird/base/content/calendar-offline.js
> These probably got in here by accident?
Yes, not checked in of course.

Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified this issue in nightly build 20080109 (Lightning and Sunbird) -> task is fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.