Closed Bug 376725 Opened 16 years ago Closed 15 years ago

test nsINavHistoryResultViewer

Categories

(Firefox :: Bookmarks & History, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha8

People

(Reporter: asaf, Assigned: dietrich)

References

Details

Attachments

(1 file, 1 obsolete file)

Apparently we don't have tests for the nsINavHistoryResultViewer API.
Flags: blocking-firefox3?
Depends on: 376726
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: --- → Firefox 3 beta1
Depends on: 370859
Depends on: 384623
Target Milestone: Firefox 3 M7 → Firefox 3 M8
Attached patch v1 (obsolete) — Splinter Review
first bit of tests for exercising NHQRN->NHRV for a history query. need to test the remaining apis for history, and then do the same for a bookmarks query
Assignee: nobody → dietrich
Status: NEW → ASSIGNED
Attached patch v2Splinter Review
added bookmarks query. a couple of TODOs, but enough done to get this in.
Attachment #275534 - Attachment is obsolete: true
Attachment #275663 - Flags: review?(sspitzer)
Comment on attachment 275663 [details] [diff] [review]
v2

r=sspitzer

I noticed a couple dump() statements that you probably want to remove or comment out before checking in.

+    dump("itemReplaced: " + newItem.uri + "\n");
+    this.replacedItem = item;

+ dump("invalidateContainer()\n");
Attachment #275663 - Flags: review?(sspitzer) → review+
Checking in toolkit/components/places/src/nsNavHistoryResult.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp,v  <--  nsNavHistoryResult.cpp
new revision: 1.112; previous revision: 1.111
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js,v
done
Checking in toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js,v  <--  test_nsINavHistoryViewer.js
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.