376725 - test nsINavHistoryResultViewer

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

Apparently we don't have tests for the nsINavHistoryResultViewer API.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: v1

first bit of tests for exercising NHQRN->NHRV for a history query. need to test the remaining apis for history, and then do the same for a bookmarks query

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: v2

added bookmarks query. a couple of TODOs, but enough done to get this in.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 275663 [details] [diff] [review]
v2

r=sspitzer

I noticed a couple dump() statements that you probably want to remove or comment out before checking in.

+    dump("itemReplaced: " + newItem.uri + "\n");
+    this.replacedItem = item;

+ dump("invalidateContainer()\n");

Comment 4

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistoryResult.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp,v  <--  nsNavHistoryResult.cpp
new revision: 1.112; previous revision: 1.111
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js,v
done
Checking in toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js,v  <--  test_nsINavHistoryViewer.js
initial revision: 1.1
done

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv