376863 - bookmarkId is set to the node type for bookmark folders?

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

node.bookmarkId for the "Bookmarks Toolbar Folder" is set to 6 for me, which happens to be node.type.

Comment 1

[Dietrich Ayala (:dietrich)]

mano, can you post your STR? I've not been able to reproduce this.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

bookmarkId property should not be set for folder nodes. (patch includes test and removes the old db dump data).

Comment 3

[Asaf Romano (gone)]

Comment on attachment 261191 [details] [diff] [review]
fix v1

r=mano.

Comment 4

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavBookmarks.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v  <--  nsNavBookmarks.cpp
new revision: 1.79; previous revision: 1.78
done
Checking in toolkit/components/places/tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.4; previous revision: 1.3
done

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv