376905 - Places bookmarks build flag doesn't influence livemark service being copied

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Gijs (he/him)]

STR:

1. Build moz without the --enable-places-bookmarks
2. Wonder why you have nsLivemarkService.js in your components dir



It should really not put files in there which are unneeded and only used with some other build flag. I wasted 2 hours due to this thing because I believed places bookmarks were enabled fine (was there an announcement about the build flag? I must have missed it) because the file was there, but it didn't actually *do anything*.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

I haven't tested this, but I'm pretty sure it should fix the problem...

Comment 2

[:Gijs (he/him)]

Comment on attachment 264732 [details] [diff] [review]
Patch

Dear Bugzilla,

Please stop not telling me when you break my changes.

Sincerely,
Gijs

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 264732 [details] [diff] [review]
Patch

passing the review buck to sayrer

Comment 4

[Robert Sayre]

Comment on attachment 264732 [details] [diff] [review]
Patch

sure, please test it before you check it in.

Comment 5

[(not reading, please use [e-mail] instead)]

fixed.

Checking in Makefile.in;
/cvsroot/mozilla/toolkit/components/places/src/Makefile.in,v  <--  Makefile.in
new revision: 1.24; previous revision: 1.23
done

Comment 6

[Robert Sayre]

Checking in src/storage-Legacy.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/src/storage-Legacy.js,v  <--  storage-Legacy.js
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/test_storage_legacy_3.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/test/unit/test_storage_legacy_3.js,v  <--  test_storage_legacy_3.js
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/passwordmgr/test/unit/data/signons-381262.txt,v
done
Checking in test/unit/data/signons-381262.txt;
/cvsroot/mozilla/toolkit/components/passwordmgr/test/unit/data/signons-381262.txt,v  <--  signons-381262.txt
initial revision: 1.1
done

Comment 7

[Robert Sayre]

gah, wrong bug. sorry.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv