376939 - static strings in nsAirbagExceptionHandler cause crash on shutdown

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Stack trace and disassembly

For some reason the static destructor of nsCString is crashing here. Attached is the stack and disassembly pointing to crashReporterAPIData.

I spoke with Ted about this and he suggested making crashReporterAPIData an nsCString*. I'm trying that now and will post a patch if it fixes the crash.

Any idea why this crashes, though?

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Oh, so that's here:

http://lxr.mozilla.org/seamonkey/source/toolkit/airbag/nsAirbagExceptionHandler.cpp#97

Comment 2

[Benjamin Smedberg]

Well, static xpcom strings are not kosher... sorry for not catching this during review. I wouldn't expect it to crash on windows, only on mac.

But yeah, we should either use nsCString* or a stdlib class of some sort.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Ted, here's one fix... what do you think? Since crashReporterFilename was only used once I just stuck it on the stack, but I'm not sure if you were planning anything else for it.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 261087 [details] [diff] [review]
Patch, v1

And I have no idea where that nsAutoPtr #include came from. Please ignore that.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 261087 [details] [diff] [review]
Patch, v1

Looks good, just make sure you don't checkin your modified dump_syms.exe.  :)

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on trunk.