Closed
Bug 376939
Opened 15 years ago
Closed 15 years ago
static strings in nsAirbagExceptionHandler cause crash on shutdown
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(2 files)
1.36 KB,
text/plain
|
Details | |
9.04 KB,
patch
|
ted
:
first-review+
|
Details | Diff | Splinter Review |
For some reason the static destructor of nsCString is crashing here. Attached is the stack and disassembly pointing to crashReporterAPIData. I spoke with Ted about this and he suggested making crashReporterAPIData an nsCString*. I'm trying that now and will post a patch if it fixes the crash. Any idea why this crashes, though?
Assignee | ||
Comment 1•15 years ago
|
||
Oh, so that's here: http://lxr.mozilla.org/seamonkey/source/toolkit/airbag/nsAirbagExceptionHandler.cpp#97
Comment 2•15 years ago
|
||
Well, static xpcom strings are not kosher... sorry for not catching this during review. I wouldn't expect it to crash on windows, only on mac. But yeah, we should either use nsCString* or a stdlib class of some sort.
Assignee | ||
Comment 3•15 years ago
|
||
Ted, here's one fix... what do you think? Since crashReporterFilename was only used once I just stuck it on the stack, but I'm not sure if you were planning anything else for it.
Assignee | ||
Updated•15 years ago
|
Attachment #261087 -
Flags: first-review? → first-review?(ted.mielczarek)
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 261087 [details] [diff] [review] Patch, v1 And I have no idea where that nsAutoPtr #include came from. Please ignore that.
Assignee | ||
Updated•15 years ago
|
Summary: static nsCString in nsAirbagExceptionHandler crashes on shutdown → static strings in nsAirbagExceptionHandler cause crash on shutdown
Comment 5•15 years ago
|
||
Comment on attachment 261087 [details] [diff] [review] Patch, v1 Looks good, just make sure you don't checkin your modified dump_syms.exe. :)
Attachment #261087 -
Flags: first-review?(ted.mielczarek) → first-review+
Assignee | ||
Comment 6•15 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•