Closed Bug 376939 Opened 15 years ago Closed 15 years ago
static strings in ns
Airbag Exception Handler cause crash on shutdown
For some reason the static destructor of nsCString is crashing here. Attached is the stack and disassembly pointing to crashReporterAPIData. I spoke with Ted about this and he suggested making crashReporterAPIData an nsCString*. I'm trying that now and will post a patch if it fixes the crash. Any idea why this crashes, though?
Well, static xpcom strings are not kosher... sorry for not catching this during review. I wouldn't expect it to crash on windows, only on mac. But yeah, we should either use nsCString* or a stdlib class of some sort.
Ted, here's one fix... what do you think? Since crashReporterFilename was only used once I just stuck it on the stack, but I'm not sure if you were planning anything else for it.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #261087 - Flags: first-review?
15 years ago
Attachment #261087 - Flags: first-review? → first-review?(ted.mielczarek)
Comment on attachment 261087 [details] [diff] [review] Patch, v1 And I have no idea where that nsAutoPtr #include came from. Please ignore that.
15 years ago
Summary: static nsCString in nsAirbagExceptionHandler crashes on shutdown → static strings in nsAirbagExceptionHandler cause crash on shutdown
Comment on attachment 261087 [details] [diff] [review] Patch, v1 Looks good, just make sure you don't checkin your modified dump_syms.exe. :)
Attachment #261087 - Flags: first-review?(ted.mielczarek) → first-review+
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.