Closed Bug 376939 Opened 16 years ago Closed 16 years ago

static strings in nsAirbagExceptionHandler cause crash on shutdown

Categories

(Toolkit :: Crash Reporting, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(2 files)

For some reason the static destructor of nsCString is crashing here. Attached is the stack and disassembly pointing to crashReporterAPIData.

I spoke with Ted about this and he suggested making crashReporterAPIData an nsCString*. I'm trying that now and will post a patch if it fixes the crash.

Any idea why this crashes, though?
Well, static xpcom strings are not kosher... sorry for not catching this during review. I wouldn't expect it to crash on windows, only on mac.

But yeah, we should either use nsCString* or a stdlib class of some sort.
Attached patch Patch, v1Splinter Review
Ted, here's one fix... what do you think? Since crashReporterFilename was only used once I just stuck it on the stack, but I'm not sure if you were planning anything else for it.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #261087 - Flags: first-review?
Attachment #261087 - Flags: first-review? → first-review?(ted.mielczarek)
Comment on attachment 261087 [details] [diff] [review]
Patch, v1

And I have no idea where that nsAutoPtr #include came from. Please ignore that.
Summary: static nsCString in nsAirbagExceptionHandler crashes on shutdown → static strings in nsAirbagExceptionHandler cause crash on shutdown
Comment on attachment 261087 [details] [diff] [review]
Patch, v1

Looks good, just make sure you don't checkin your modified dump_syms.exe.  :)
Attachment #261087 - Flags: first-review?(ted.mielczarek) → first-review+
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.