Useless margin-top rules in quirk.css for form?

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: Martijn Wargers (zombie))

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(11 attachments)

(Assignee)

Description

11 years ago
See url, since form is already set to to margin-top: 0 at:
http://lxr.mozilla.org/seamonkey/source/layout/style/quirk.css#288
the form selector part there seems rather useless. So I think those can be removed.

IE seems to have margin-top: 1em for forms, so maybe we want to follow that instead.
(Assignee)

Comment 1

11 years ago
Created attachment 261057 [details]
testcase1, form that is no first or last node
(Assignee)

Comment 2

11 years ago
Created attachment 261058 [details]
testcase2, form is first-node
(Assignee)

Comment 3

11 years ago
Created attachment 261059 [details]
testcase3, form is last-node
(Assignee)

Comment 4

11 years ago
Created attachment 261060 [details]
testcase4, form is first-node in td
(Assignee)

Comment 5

11 years ago
Created attachment 261061 [details]
testcase5, form is last-node in td
(Assignee)

Comment 6

11 years ago
Results for IE:
             margin-top?  margin-bottom?
testcase1 -  yes          yes
testcase2 -  no           yes
testcase3 -  yes          -
testcase4 -  no           yes
testcase5 -  yes          yes
(Assignee)

Comment 7

11 years ago
Created attachment 261072 [details]
261057: testcase1a, empty form that is no first or last node
(Assignee)

Comment 8

11 years ago
Created attachment 261073 [details]
testcase2a, empty form is first-node
(Assignee)

Comment 9

11 years ago
Created attachment 261074 [details]
testcase3a, empty form is last-node
(Assignee)

Comment 10

11 years ago
Created attachment 261075 [details]
testcase4a, empty form is first-node in td
(Assignee)

Comment 11

11 years ago
Created attachment 261076 [details]
testcase5a, empty form is last-node in td
(Assignee)

Comment 12

11 years ago
Same result in IE7 for these testcases.
(Assignee)

Comment 13

11 years ago
Created attachment 261080 [details] [diff] [review]
patch

This patch makes Mozilla behave differently in these cases:
-testcase2a, empty form is first-node
-testcase4a, empty form is first-node in td
But that makes Mozilla actually more compatible with IE.
Attachment #261080 - Flags: review?(dbaron)

Comment 14

11 years ago
Comment on attachment 261080 [details] [diff] [review]
patch

r+sr=dbaron.  Sorry for taking so long to get to this.
Attachment #261080 - Flags: superreview+
Attachment #261080 - Flags: review?(dbaron)
Attachment #261080 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #261080 - Flags: approval1.9?

Comment 15

11 years ago
Comment on attachment 261080 [details] [diff] [review]
patch

a1.9=dbaron
Attachment #261080 - Flags: approval1.9? → approval1.9+
Assignee: nobody → martijn.martijn
(Assignee)

Comment 16

11 years ago
Checking in quirk.css;
/cvsroot/mozilla/layout/style/quirk.css,v  <--  quirk.css
new revision: 1.57; previous revision: 1.56
done

Checked into trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.