376959 - Polish platform specific respin support

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

There are few parts to this, and I'm likely to miss something, but the rough idea is:

- be able to respin a single platform
- set up symlinks appropriately between candidate directories
- be smart about update generation and coping with symlinks

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Follow symlinks when doing Repack verification

When we use symlinks, we need to use rsync -L to follow them when doing the Repack verification.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Forgot to say that it looks like the only other step using rsync is Stage, and that already got the -L treatment (where needed).

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 267443 [details] [diff] [review]
Follow symlinks when doing Repack verification

Do we want this to be -Lav? I believe that's what the stage step has; I can't remember if there was a reason we didn't do -a here. If there wasn't, should we standardize, so we have -a?

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

needed for "release automation", hence marking as critical.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #3)
> (From update of attachment 267443 [details] [diff] [review])
> Do we want this to be -Lav? I believe that's what the stage step has; I can't
> remember if there was a reason we didn't do -a here. If there wasn't, should we
> standardize, so we have -a?

I added the -a argument to standardize - it shouldn't make a difference as the metadiff is looking at the contents of the transferred archive/installer. 

Checking in Bootstrap/Step/Repack.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Repack.pm,v  <--  Repack.pm
new revision: 1.13; previous revision: 1.12
done

Comment 6

[Robert Helmer [:rhelmer]]

Nick, what is left to do here? 

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I guess we hack up the buildbot config to respin a single platform now, so point one is covered (after a fashion). TBH I don't recall all the context, so lets mark this FIXED and follow up as needed.