377045 - Crash in nsDocAccessible::GetParent()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Missing null pointer check.

Comment 1

[Aaron Leventhal]

Attachment: Null checks

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 261157 [details] [diff] [review]
Null checks

>Index: accessible/src/base/nsDocAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v
>retrieving revision 1.132
>diff -p -u -5 -r1.132 nsDocAccessible.cpp
>--- accessible/src/base/nsDocAccessible.cpp	10 Apr 2007 16:28:38 -0000	1.132
>+++ accessible/src/base/nsDocAccessible.cpp	10 Apr 2007 17:26:35 -0000
>@@ -439,25 +439,26 @@ NS_IMETHODIMP nsDocAccessible::CacheAcce
> 
> NS_IMETHODIMP nsDocAccessible::GetParent(nsIAccessible **aParent)
> {
>   // Hook up our new accessible with our parent
>   if (!mParent) {
>+    *aParent = nsnull;
>+    NS_ENSURE_TRUE(mDocument, NS_ERROR_FAILURE);

Probably you should move these lines on top of the method. I think doc accessible cannot have parent without mDocument.