377131 - spell checker changes first upper-case character to lower case

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Jeroen de Bruin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 1.5.0.10 (20070221)

Using the spell checker in TB to correct words (right-click, select right one from the list), words automatically get converted to lower-case.

So for example when correcting the first word of a sentence, this happens (Spanish spell check):
Tambien => también 

Reproducible: Always

Steps to Reproduce:
1. write word wrong with first character upper-case, rest lower-case
2. word gets underlined (red)
3. right-click and select right word from list
Actual Results:  
word gets converted to all lower-case

Expected Results:  
First character upper-case, the rest lower-case

Case of characters should not be changed, regardless of how many upper- / lower-case characters in the word.

Comment 1

[Magnus Melin [:mkmelin]]

Don't see this with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4pre) Gecko/20070410 Thunderbird/2.0.0.0pre ID:2007041003

... with en-US. Moving to moz localizations.

Comment 2

[Jeroen de Bruin]

I'm using the English (en-US) 1.5.0.10 (20070221) version with dictionaries copied from OpenOffice.

Comment 3

[RickieES aka Ricardo Palomares]

(In reply to comment #2)
> I'm using the English (en-US) 1.5.0.10 (20070221) version with dictionaries
> copied from OpenOffice.
> 


I've tested localized es-ES Thunderbird 2.0pre 20070326 with the es-ES dictionary from AMO (https://addons.mozilla.org/en-US/firefox/browse/type:3) and everything works as intended (capitalized words are corrected keeping the capitalization). If this was an error due to translation in TB 1.5, I don't think we can get approval for a check in on MOZILLA_1_8_0_BRANCH anymore, and it looks like TB 2.0 won't have this problem.

Since we are so close to TB 2.0 launch, I'll wait for a few days so the original reporter can comment.

Comment 4

[Jeroen de Bruin]

I'll definitely use the en_US version of 2.0 as well (any English version, not Spanish or any other language) but if that new version solves the problem, I'll be all happy / the problem is solved.

Thanks for the feedback and efforts,
Jeroen

Comment 5

[Jeroen de Bruin]

Nope, just installed version 2.0.0.0 (20070326) en-US, installed Spanish dictionary from https://addons.mozilla.org/en-US/thunderbird/browse/type:3 and exactly the same thing happens (see original description):

Tambien => también

Note: It's a problem with the Spanish dictionary; the English (or Dutch) version - when selected for the same text - gives words with the first character capitalized. Happens in the Spanish dictionaries of both Firefox (2.0.0.3) and Thunderbird (2.0.0.0).

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #5)
> Nope, just installed version 2.0.0.0 (20070326) en-US, installed Spanish
> dictionary from https://addons.mozilla.org/en-US/thunderbird/browse/type:3 and
> exactly the same thing happens (see original description):
> 
> Tambien => también
> 
> Note: It's a problem with the Spanish dictionary; the English (or Dutch)
> version - when selected for the same text - gives words with the first
> character capitalized. Happens in the Spanish dictionaries of both Firefox
> (2.0.0.3) and Thunderbird (2.0.0.0).


Funnily enough, I've just managed to reproduce the exact problem with the shipped en-US dictionary on Thunderbird trunk en-US (20070418)!! In my setup, I've written this:

  ...checkers. Thiz is too...

Checking spelling catchs "Thiz" as an error and gives me this exact list of possible replacements (capitalization has been honored):

whiz
Thia
this
thin

Choosing "this" results in the initial uppercase letter converted to lowercase.

Even funnier, I've installed the spanish dictionary from AMO, and I've tried to reproduce the error in spanish ("Tambén" -> "También") and the capital letter has been honored!! One thing to note is that, in the possible replacements, "También" was capitalized. When I used "tambén", I got "también" as replacement, in lower case.

Could it be that honoring the capital letter entirely depends on the dictionary having the word capitalized or not?

Comment 7

[Jeroen de Bruin]

Thanks, I was starting to think it was me!

Anyway, looks like you've got it right:
Extrano => Extrajo or Extraño or Extra no
ExTrano => extrajo or extraño or extra no (all lower case)

But this (upper / lower case) should be in the program, not the dictionary. In my opinion that is...

Comment 8

[RickieES aka Ricardo Palomares]

After all tests reported in this bug, I'd bet it has nothing to do with the localization itself. I'm moving it back to Thunderbird product, because I don't really know if there is an actual bug or not. BTW, I forgot to say that I've been testing on Linux, so it is not related to an specific OS either.

Comment 9

[Jim Warren]

I have just reproduced this error using the English/United Kingdom dictionary and Thunderbird 2.0.0.6 on Windows XP.

I believe the analysis in comment #6 is right, and whether the word is capitalised or not in the dictionary wrongly takes precedence over whether the word is capitalised or not in the text being spell checked.  It doesn't seem to matter which dictionary is used, only which words are capitalised within it.  So I go along with Comment #8 in that it isn't a localisation issue.

What is needed is for the upper/lower case presentation in the text being spell checked to be preserved when corrected to a lower case entry in the dictionary.

Comment 10

[Mike Lierman]

This seems to be Firefox 3 branch. Please try Firefox 3 Beta 3 (http://www.mozilla.com/en-US/firefox/3.0b3/releasenotes/#download). A word to try, that I tried in this text field when commenting is type "Cromputer" with a capital 'C' now right click and select Computer and notice it leaves the capitalization. It is fixed in Firefox 3 branch.


Bug is now waiting for Check-In and VERIFIED that it is fixed (by me).


-Mike

Comment 11

[Jeroen de Bruin]

The initial problem is with Thunderbird although it happens with Firefox as well.

Furthermore using Firefox 2.0.0.12 en-US I can type in Cromputer and have it corrected to Computer (only option in the list).

See also comment 6; some words seem to be stored in the dictionary with initial capitals.

Comment 12

[Mike Lierman]

Do you guys still think this is an issue? If not then I will go ahead and mark as "WORKSFORME".

Please let me know, as it works here.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008030405 Minefield/3.0b5pre

-Mike

Comment 13

[Jeroen de Bruin]

I have just tried it again (TB 2.0.0.12, Win XP Home SP2) and nothing has changed so the original problem still exists and as far as I am concerned it is still annoying.

Comment 14

[Magnus Melin [:mkmelin]]

You need a ff3.0 (beta3/4...) or thunderbird 3.0 a1pre to see it.

->WFM