377182 - Incorrect RDF file prevents dictionary updates

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Dictionaries, defect)

Description

[Paul Schmiedge]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Dictionaries hosted on AMO cannot update.  Turning on extensions logging (extensions.logging.enabled = 1) and watching the Error console reveals the following error:

--
RDFItemUpdater:_parseV20UpdateInfo: No updates were found for:
[e-mail]
If you are an Extension developer and were expecting there to be
updates, this could mean any number of things, since the RDF system
doesn't give up much in the way of information when the load fails.

Try checking that: 
 1. Your RDF File is correct - e.g. check that there is a top level
    RDF Resource with a URI urn:mozilla:extension:{GUID}, and that
    the <em:updates> listed all have matching GUIDs.
--

The MinVersion for the extension is valid.

Reproducible: Always

Steps to Reproduce:
1. Install a dictionary that has a newer version hosted at AMO.
2. Use the extension manager to update the dictionary.


Actual Results:  
Dictionary does not update.  An RDF parse error is logged to the Error Console.

Expected Results:  
Dictionary should have updated to latest version hosted at AMO.

To test this with an dictionary that is already at the newest version, simply turn on extension logging and attempt to update the dictionary.  The RDF error still appears.

Comment 1

[Paul Schmiedge]

Attachment: Returned RDF when updating the en-CA dictionary

I believe the error is because AMO identifies dictionaries with the 'urn:mozilla:dict' prefix.  From looking at nsExtensionManager.js, I don't think Firefox or Thunderbird can understand this prefix.

Comment 2

[Justin Scott [:fligtar]]

We recently made some changes (see bug 367417) - are you still having this problem?

Comment 3

[Paul Schmiedge]

(In reply to comment #2)
> We recently made some changes (see bug 367417) - are you still having this
> problem?
> 

Yes, the error message still occurs and the update still does not happen.  This is in Firefox and Thunderbird.  The minVersion is correctly set to 2.0 for both applications.  The RDF that is returned (see comment #1) clearly shows that a newer version is available, but neither Firefox (2.0.0.3) nor Thunderbird (2.0.0.0) install it.  I can produce a version of the RDF for both applications, if that would help.

Comment 4

[Justin Scott [:fligtar]]

This bug makes me feel pretty dumb for multiple reasons, not the least of which is that I just spent 45 minutes debugging and coming to the same conclusion that was conveniently already posted in comment #1.

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#129

We can't use our own made up stuff there, we have to use extension or theme. I tested this on a local update.rdf changing dict to extension and the update was offered as expected -- apparently dictionary updates have been broken since Remora's launch.

I'm sorry we didn't address this sooner.

Comment 5

[Justin Scott [:fligtar]]

Attachment: fix

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 262076 [details] [diff] [review]
fix

r=shaver

Comment 7

[Justin Scott [:fligtar]]

Checked in and tagged for production; this should go live tonight.

Comment 8

[Justin Scott [:fligtar]]

Verified in production: all the dictionaries I installed to test this now show updates.

Comment 9

[Paul Schmiedge]

Thanks, Justin - all's well from my point of view, too.