377253 - XUL Widget Cleanup

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Neil Deakin]

Attachment: Tests properties of each XUL element

This is a metabug for various cleanups I want to do on the xul widgets xbl (toolkit/content/widgets). The attachment is a testcase based on one from bug 368097 which tests each widget for all the interfaces, properties and methods.

I'll be filing bugs dependent on this one which fix the testcase so that it outputs no fail rows.

The bugs also will fix various stylistic issues such as
 - use underscore prefix consistently for 'private' fields
 - make sure readonly properties are marked as such
 - ensure each widget implements the right interfaces and that the interfaces are actually implemented
 - more consistent handling of booleans using setAttribute/removeAttribute style
 - ensure setters return val

as well as fixing various bugs.

Comment 1

[Neil Deakin]

Adding some dependencies. Any other bugs pertaining to the xbl implementation of XUL widgets to fix for 1.9 should be added as well.