Closed
Bug 377295
Opened 17 years ago
Closed 17 years ago
Mochikit test for bug 366770 fails for me, because constructor can be run after onload
Categories
(Core :: XBL, defect, P3)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: martijn.martijn, Assigned: Gavin)
References
()
Details
(Keywords: testcase)
Attachments
(2 files)
|
1.33 KB,
text/html
|
Details | |
|
3.19 KB,
patch
|
martijn.martijn
:
review+
|
Details | Diff | Splinter Review |
See testcase, it alerts 'undefined' for me, but the way the mochikit test is made, it expects 'true' as the outcome for the alert. The mochikit test should not expect that the constructor has been run after onload of the document.
|
Assignee | |
Comment 1•17 years ago
|
||
Moves the finish() call into the constructor.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #263173 -
Flags: review?(martijn.martijn)
|
|
Assignee | |
Updated•17 years ago
|
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha5
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 263173 [details] [diff] [review] patch Ok, thanks, that seems right to me.
Attachment #263173 -
Flags: review?(martijn.martijn) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
mozilla/content/xbl/test/test_bug366770.html 1.2
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 4•17 years ago
|
||
Is there a bug on the underlying problem here? Constructor execution should perhaps block onload...
|
||
Updated•17 years ago
|
Flags: in-testsuite+
|
||
Updated•16 years ago
|
Component: Testing → XBL
QA Contact: testing → xbl
You need to log in
before you can comment on or make changes to this bug.
Description
•