377339 - When files are saved in a loop, the download manager opens once for each file.

Status: NEW

(Toolkit :: Downloads API, defect)

Description

[Florian Quèze [:florian]]

In the media tab of Page Info when we save more than one image at a time, if the save function is called in a loop, the download manager window opens for each file, and all the window but the last are broken.

When calling the save function using setTimeout there's no problem.

Comment 1

[Shawn Wilsher :sdwilsh]

sample code to reproduce?  I don't see how this would cause a problem.

Comment 2

[Florian Quèze [:florian]]

(In reply to comment #1)
> sample code to reproduce?

Try removing the setTimeout hack in the function saveMedia of pageInfo.js

Comment 3

[Florian Quèze [:florian]]

Attachment: diff to reproduce

I can still reproduce.

Steps to reproduce:
1. Apply the attached diff, build, launch Minefield
2. Load a page with more than one image
3. Open Page Info, in the Media tab, select more than one image and save them.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)