377362 - Export DER_Generalized* and DER_TimeChoice* functions

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

NSS has a set of functions for working with UTCTime strings, such as 
DER_UTCDayToAscii.  These are exported, part of the public API.
Those functions return NULL or other improper values when the strings 
are actually GeneralizedTime strings.  

So, how are applications supposed to work with GeneralizedTimes and 
TimeChoices??

NSS also has DER_Generalized* functions, such as DER_GeneralizedDayToAscii
for GeneralizeTimes, and DER_TimeChoice* functions, such as 
DER_TimeChoiceDayToAscii for timeChoices.  But they're not exported !

So this RFE requests that all the DER_Generalized* and DER_TimeChoice*
funtions, corresponding to the existing exported DER_UTC functions, 
be exported.  

GUI admin tools for Sun servers want this.

Comment 1

[Julien Pierre]

There are 5 relevant to this RFE :

secder.h:extern char *DER_GeneralizedDayToAscii(SECItem *gentime);
secder.h:extern SECStatus DER_TimeToGeneralizedTime(SECItem *dst, int64 gmttime);
secder.h:extern SECStatus DER_TimeToGeneralizedTimeArena(PRArenaPool* arenaOpt,
                                                SECItem *dst, int64 gmttime);
secder.h:extern SECStatus DER_GeneralizedTimeToTime(int64 *dst, const SECItem *time);
secder.h:extern char *DER_TimeChoiceDayToAscii(SECItem *timechoice);

The following two functions dealing with time choices are already exported since 3.9 :

secder.h:extern SECStatus DER_DecodeTimeChoice(PRTime* output, const SECItem* input);
secder.h:extern SECStatus DER_EncodeTimeChoice(PRArenaPool* arena, SECItem* output,
                                       PRTime input);

I will add a patch that exports the 5 existing functions for NSS 3.11.7 .

Comment 2

[Julien Pierre]

I meant 5 relevant functions in comment 1. And there are only 4 actually - DER_GeneralizedTimeToTime was already exported since 3.2 .

Comment 3

[Julien Pierre]

Attachment: Export 4 additional functions

Note that this patch applies to both the branch and trunk. I'm requesting review for both.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 262699 [details] [diff] [review]
Export 4 additional functions

r=nelson

Comment 5

[Julien Pierre]

Thanks for the reviews.

I checked this in to the branch.

Checking in nss.def;
/cvsroot/mozilla/security/nss/lib/nss/nss.def,v  <--  nss.def
new revision: 1.158.2.7; previous revision: 1.158.2.6
done

As well as to the trunk.
Checking in nss.def;
/cvsroot/mozilla/security/nss/lib/nss/nss.def,v  <--  nss.def
new revision: 1.173; previous revision: 1.172
done