377404 - Should check the scrolling direction in nsMouseWheelTransaction

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: testcase

I was confused by the current mouse wheel transaction.

A page has large scrollable view which has only vertical scrollbar. And the page has both scrollbars on a body. I moved the cursor into the child scrollable view and scrolled the view to vertical for reading the content. And then, I wanted to scroll the horizontal direction on the body. For doing it, I used the tilt wheel. But the horizontal scroll events were eaten by the child scrollable view. So, there were not any changes in the view. Therefore, I was confused some seconds (although I have implemented it).

I think that if the current target cannot be scrolled to a direction, but the event came to ESM, the user want to scroll another view. The current transaction should be finished in such case.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: Patch rv1.0

The transaction manager should keep and check the scrolling direction. And if the mis-direction scrolling events are fired immediately before/after other direction scrolling event, the events may be mis-inputted, then, we should ignore these events.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

And I thought whether I should change the transaction manager keeping only one direction. But I believe that it is a wrong approach. Because I have looked the mouse with stick instead of wheel. Which can scroll to 8 directions.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: Patch rv1.0.1

Sorry, the patch is not latest.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: Patch rv1.0.1

Oops, sorry for the spam...

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Mats:

would you review this?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: Patch rv1.0.2

Updating for latest trunk.

Mats:

Would you review this? I'm still waiting...

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Comment on attachment 275442 [details] [diff] [review]
Patch rv1.0.2

Roc, would you review this?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Do we really need the misdirection timer? Are there many devices where it's easy to scroll in the wrong direction?

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

(In reply to comment #8)
> Do we really need the misdirection timer? Are there many devices where it's
> easy to scroll in the wrong direction?

I'm using MS Wireless Laser Mouse 8000. When I use horizontal scroll with it, the wheel is moved to vertical at leaving my finger from the wheel...

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

(In reply to comment #9)
> (In reply to comment #8)
> > Do we really need the misdirection timer? Are there many devices where it's
> > easy to scroll in the wrong direction?
> 
> I'm using MS Wireless Laser Mouse 8000. When I use horizontal scroll with it,
> the wheel is moved to vertical at leaving my finger from the wheel...

er, I often experience it.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I wonder this is something we should fix for 1.9, though. Can you nominate it for 1.9 blocking status and we'll see what happens?

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

roc:

I think that the misdirection timer is really quirk for the "bug" of some device. Here is an alternative: We cache two targets; one is for vertical and other one is for horizontal. It can remove the problems and the misdirection timer. *However*, is it intuitive?

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That sounds OK.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Not a blocker, might still want to take the patch after beta though.

Comment 15

[Damon Sicore (:damons)]

Comment on attachment 275442 [details] [diff] [review]
Patch rv1.0.2

-'ing the approval request.  Please re-request approval once reviews are completed.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Masayuki, are you going to update this patch?

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

fixed by bug 442774.

The failing to scroll events are not update the current transaction. Therefore, if you fire the wrong direction events continuously, the target frame will be switched by timeout.