Closed
Bug 377409
Opened 17 years ago
Closed 17 years ago
Create toplevel targets for all products to create tarballs and installers
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
2.31 KB,
patch
|
preed
:
review+
|
Details | Diff | Splinter Review |
Currently to make a tarball or an installer, you have to make a target in a special directory per-app: browser/installer for Firefox mail/installer for Tbird xpinstall/packager for suite This is silly. We should have a toplevel makefile target that does the Right Thing. This will reduce the amount of tinderbox logic we need (at least eventually), and will make FF+XR easier to manage.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #261486 -
Flags: review?(preed)
Comment 2•17 years ago
|
||
Comment on attachment 261486 [details] [diff] [review] Unified toplevel targets, rev. 1 Looks good; the only suggestion I might make is that installer, as a target, makes sense, but tarball, as a target, makes less sense in the case where on other platforms, you get something else (.zip on Win32, .??? on Mac?) A "package" target or something might be clearer. (We're just debating all sorts of names today, aren't we?) Other than that, this is going to be very helpful, I think. :-)
Attachment #261486 -
Flags: review?(preed) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Fixed on trunk a couple days ago with "package" instead of "tarball".
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•