Closed Bug 377449 Opened 16 years ago Closed 16 years ago

nsXULTooltipListener::LaunchTooltip() doesn't need arguments.

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

Details

Attachments

(1 file)

Right now there's only one caller of nsXULTooltipListener::LaunchTooltip() and it passes in member variables as arguments. Those are obviously available to LaunchTooltip() itself, so there's no need to pass them in. Also, the caller doesn't care about the return code... Patch coming up.
Attachment #261518 - Flags: superreview?(neil)
Attachment #261518 - Flags: review?(neil)
Comment on attachment 261518 [details] [diff] [review]
Remove unnecessary arguments.

>-      LaunchTooltip(mSourceNode, mMouseClientX, mMouseClientY);
>-nsXULTooltipListener::LaunchTooltip(nsIContent* aTarget, PRInt32 aX, PRInt32 aY)
Sorry for the delay - nothing to do with -p, but rather overlooking the fact that we used to pass mSourceNode as aTarget which made the following look odd:
>-    nsCOMPtr<nsIDOMElement> targetEl(do_QueryInterface(aTarget));
>+    nsCOMPtr<nsIDOMElement> targetEl(do_QueryInterface(mSourceNode));
Attachment #261518 - Flags: superreview?(neil)
Attachment #261518 - Flags: superreview+
Attachment #261518 - Flags: review?(neil)
Attachment #261518 - Flags: review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.