377602 - Downloads pref pane has very odd definition of "successful"

Status: RESOLVED WONTFIX

(Camino Graveyard :: Downloading, defect)

Description

[Chris Lawson (gone)]

Along the same lines as bug 371335, if you quit Camino with active downloads, you get a warning that those downloads will be cancelled if you quit.

That's all well and good, but when you re-start Camino and have "Remove successful downloads: When Camino quits" selected in the Downloads pref pane, your downloads list is now devoid of the downloads that were active when you quit.

"Cancelled" does not equal "successful" by any definition with which I'm familiar. Either we need to re-think our wording here or we need to fix behaviour to be more in line with the wording we have. If we change behaviour, I suggest *pausing* the downloads on quit and leaving them in the manager so they can be resumed at the user's discretion. (I realise not all servers support resumable downloads; for such servers, the right solution is probably to simply leave the cancelled download in the manager rather than removing it.)

Comment 1

[Chris Lawson (gone)]

Another possibility I just thought of -- it may be that when quitting, we are marking any cancelled downloads as "completed" rather than "cancelled", in which case that's clearly a bug and should be fixed (which, in turn, would solve this problem as filed).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We can't pause downloads between sessions; we can only cancel them.  When bug 215343 lands, we will be able to resume them from where they left off (if the server supports it).

We should check out comment 1 first and see what's actually happening in this case.

Comment 3

[Chris Lawson (gone)]

Either way there's something buggy here, so I'm confirming this.

Nick, do you remember anything about what might be happening here from back when you were working on our download stuff regularly?

Comment 4

[Ilya Sherman]

Attachment: Sample stack trace

Seems it's being marked as completed, though I can't quite tell -- Gecko code is kinda hard to follow...

(To get the stack, you can put a breakpoint on [ProgressViewController downloadDidEnd])

Comment 5

[Chris Lawson (gone)]

Ilya said he could take a look at this, and I'm more than happy to help as needed.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]